All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6: Fix use of improper value in enable_ipu_clock
Date: Mon, 23 Sep 2013 10:15:26 -0700	[thread overview]
Message-ID: <5240772E.70103@boundarydevices.com> (raw)
In-Reply-To: <69b4c52c2f049e7def7dc9d4b668a8a90243d9c5.1379935205.git.p.aubert@staubli.com>

On 09/23/2013 04:37 AM, Pierre Aubert wrote:
> The value MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET that was used to initialize
> the CCGR3 register caused an undefined value for CG0.
>
> Signed-off-by: Pierre Aubert <p.aubert@staubli.com>
> CC: Stefano Babic <sbabic@denx.de>
> ---
>   arch/arm/cpu/armv7/mx6/clock.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
> index 7efb0d2..0f7bcbc 100644
> --- a/arch/arm/cpu/armv7/mx6/clock.c
> +++ b/arch/arm/cpu/armv7/mx6/clock.c
> @@ -457,7 +457,7 @@ void enable_ipu_clock(void)
>   	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
>   	int reg;
>   	reg = readl(&mxc_ccm->CCGR3);
> -	reg |= MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET;
> +	reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
>   	writel(reg, &mxc_ccm->CCGR3);
>   }
>   /***************************************************/
>

Acked-by: Eric Nelson <eric.nelson@boundarydevices.com>

  reply	other threads:[~2013-09-23 17:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23 11:37 [U-Boot] [PATCH] mx6: Fix use of improper value in enable_ipu_clock Pierre Aubert
2013-09-23 17:15 ` Eric Nelson [this message]
2013-09-27 12:06   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5240772E.70103@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.