Re: [PATCH v4] media: st-rc: Add ST remote control driver

[Srinivas KANDAGATLA <srinivas.kandagatla@st.com>]

Thanks Stephen,
On 23/09/13 21:40, Stephen Warren wrote:
> On 09/19/2013 02:59 AM, Srinivas KANDAGATLA wrote:
>> This patch adds support to ST RC driver, which is basically a IR/UHF
>> receiver and transmitter. This IP (IRB) is common across all the ST
>> parts for settop box platforms. IRB is embedded in ST COMMS IP block.
>> It supports both Rx & Tx functionality.
>>
>> In this driver adds only Rx functionality via LIRC codec.
> 
>> diff --git a/Documentation/devicetree/bindings/media/st-rc.txt b/Documentation/devicetree/bindings/media/st-rc.txt
> 
>> +Required properties:
>> +	- compatible: should contain "st,comms-irb".
>> +	- reg: base physical address of the controller and length of memory
>> +	mapped  region.
> 
> Nits:
> 
> The indentation is a little odd here; I'd expect the - to be in column
> 1, at least that's how most other binding docs are written. Not a big
> deal though.
> 
> It'd be nice to indent the continuation lines (e.g. "mapped region") a
> bit more so it's easier to see where each new entry starts.
> 
> There are two spaces in "mapped  region".
I should have noticed it... I will fix it in next version.
> 
>> +	- rx-mode: can be "infrared" or "uhf". rx-mode should be present iff the
>> +	  rx pins are wired up.
>> +	- tx-mode: should be "infrared". tx-mode should be present iff the tx
>> +	  pins are wired up.
> 
> Should those property names be prefixed with "st,"; I assume they're
> specific to this binding rather than something generic that applies to
> all IR controller bindings? If you expect them to be generic, it's fine.

Officially these bindings are not specified in ePAPR specs but I see no
reason for not having these properties as generic ones.

Are you ok with that?

> 
>> +	- clocks : phandle with clock-specifier pair.
> 
> For what clock?
Its Clock for IRB block. I will add this in next version.
> 
> 

Thanks,
srini