Re: [PATCH 2/2] android: Android version of log.c

[Frederic Danis <frederic.danis@linux.intel.com>]

Hello Marcel,

On 21/09/2013 19:20, Marcel Holtmann wrote:
<snip>
>> @@ -110,10 +137,22 @@ int main(int argc, char *argv[])
>> 	sa.sa_handler = signal_handler;
>> 	sigaction(SIGINT, &sa, NULL);
>> 	sigaction(SIGTERM, &sa, NULL);
>> +	sigaction(SIGUSR2, &sa, NULL);
>> +
>> +	__btd_log_init(option_debug, option_detach);
>> +
>> +	/* no need to keep parsed option in memory */
>> +	free_options();
>> +
>> +	DBG("Entering main loop");
>
> Don't do this debug. It is not helpful. The main() is so short, no point in logging that.

I need at least one DBG call to be able to build, otherwise I got 
"undefined reference to `__start___debug'" error messages.
So, this one seems ok to me.

Regards

Fred

-- 
Frederic Danis                            Open Source Technology Center
frederic.danis@intel.com                              Intel Corporation