Re: [Qemu-devel] [PATCH V4] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

On 09/24/2013 09:07 AM, Benoît Canet wrote:
> Some drivers will have driver specifics options but no filename.
> This new bool allow the block layer to treat them correctly.
> 
> The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filename and
> not having .bdrv_open.
> 
> The first exception to this rule will be the quorum driver.
> 
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  block.c                   | 5 +++--
>  block/gluster.c           | 4 ++++
>  block/iscsi.c             | 1 +
>  block/raw-posix.c         | 5 +++++
>  block/raw-win32.c         | 2 ++
>  block/rbd.c               | 1 +
>  block/sheepdog.c          | 3 +++
>  include/block/block_int.h | 6 ++++++
>  8 files changed, 25 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]