From: Chen Gang <gang.chen@asianux.com>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: [PATCH] kernel/groups.c: consider about NULL for 'group_info' in all related extern functions
Date: Wed, 25 Sep 2013 08:49:31 +0800 [thread overview]
Message-ID: <5242331B.4010309@asianux.com> (raw)
In-Reply-To: <20130924120429.GA2366@htj.dyndns.org>
On 09/24/2013 08:04 PM, Tejun Heo wrote:
> On Tue, Sep 24, 2013 at 12:27:36PM +0800, Chen Gang wrote:
>> For real world, /sbin/init will call setgroups, so user space 'help'
>> kernel itself to protect this issue, but I think, we don't only depend
>> on the user space help checking.
>>
>> The proof is below:
>>
>> [root@gchenlinux tmp]# grep setgroups /sbin/*
>> Binary file /sbin/init matches
>> Binary file /sbin/rpc.statd matches
>> Binary file /sbin/rsyslogd matches
>> Binary file /sbin/runuser matches
>>
>> From reading kernel source code, kernel itself does not intend to set
>> 'group_info', it is triggered by user space or another kernel mode
>> sub-systems.
>
> Can you please demonstrate such failure? You can tell kernel to
> execute a given binary instead of init with "init=" param.
>
OK, I will/should try, today (although I have to spend my additional
time resource on it. :-( ).
Hmm... in fact, in my opinion, interface (especially content system
call) need make itself consistency, although at present, it can not
cause issue.
> Thanks.
>
Thanks.
--
Chen Gang
next prev parent reply other threads:[~2013-09-25 0:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 3:01 [PATCH] kernel/groups.c: consider about NULL for 'group_info' in all related extern functions Chen Gang
2013-08-20 3:03 ` Chen Gang
2013-09-03 5:23 ` Chen Gang
2013-09-23 15:06 ` Tejun Heo
2013-09-24 3:42 ` Chen Gang
2013-09-24 4:06 ` Tejun Heo
2013-09-24 4:27 ` Chen Gang
2013-09-24 12:04 ` Tejun Heo
2013-09-25 0:49 ` Chen Gang [this message]
2013-09-25 0:58 ` Tejun Heo
2013-09-25 1:06 ` Chen Gang
2013-09-25 1:14 ` Tejun Heo
2013-09-25 1:47 ` Chen Gang
2013-09-25 4:34 ` Chen Gang
2013-09-26 5:58 ` Chen Gang
2013-09-26 6:30 ` Chen Gang
2013-09-26 13:15 ` Tejun Heo
2013-09-27 1:30 ` Chen Gang
2013-09-27 3:36 ` Tejun Heo
2013-09-27 7:16 ` Chen Gang
2013-09-27 11:53 ` Tejun Heo
2013-09-27 12:19 ` Chen Gang
2013-09-29 2:50 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5242331B.4010309@asianux.com \
--to=gang.chen@asianux.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.