From: Sourav Poddar <sourav.poddar@ti.com>
To: Huang Shijie <b32955@freescale.com>
Cc: artem.bityutskiy@linux.intel.com, balbi@ti.com,
broonie@kernel.org, linux-mtd@lists.infradead.org,
computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH] drivers: mtd: m25p80: Add quad read support.
Date: Wed, 25 Sep 2013 11:24:39 +0530 [thread overview]
Message-ID: <52427A9F.9070107@ti.com> (raw)
In-Reply-To: <524279F2.5020801@ti.com>
On Wednesday 25 September 2013 11:21 AM, Sourav Poddar wrote:
> On Wednesday 25 September 2013 11:18 AM, Huang Shijie wrote:
>> 于 2013年09月24日 20:10, Sourav Poddar 写道:
>>> + flash->quad_read = false;
>>> + if (spi->mode&& SPI_RX_QUAD) {
>>> + quad_enable(flash);
>>> + flash->mtd._read = m25p80_quad_read;
>>> + flash->quad_read = true;
>>> + } else
>>> + flash->mtd._read = m25p80_read;
>> How do you know the NOR support the QUAD read? by the spi->mode?
>>
>> i think you'd better add a DT node such as "m25p, quad-read".
> no need to add a new property, support is already there.
>
> If you see spi.c, "spi-rx-bus-width" property is already added. We
> will set this
> property in dts to 4 in case of quad read. Once this is set, spi->mode
> will
> be set to SPI_RX_QUAD in spi.c. which can be used by mtd layer to
> device whether
Sorry for the
typo..
^^^^
decide
> flash supports quad read or not.
>>
>> thanks
>> Huang Shijie
>>
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2013-09-25 5:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 12:10 [PATCH] drivers: mtd: m25p80: Add quad read support Sourav Poddar
2013-09-25 3:06 ` Huang Shijie
2013-09-25 5:20 ` Sourav Poddar
2013-09-25 5:48 ` Huang Shijie
2013-09-25 5:51 ` Sourav Poddar
2013-09-25 5:54 ` Sourav Poddar [this message]
2013-09-25 5:56 ` Huang Shijie
2013-09-25 6:16 ` Huang Shijie
2013-09-25 6:24 ` Sourav Poddar
-- strict thread matches above, loose matches on Subject: below --
2013-10-25 9:25 Sourav Poddar
2013-10-25 10:18 ` Huang Shijie
2013-10-25 10:19 ` Sourav Poddar
2013-10-27 16:45 ` Marek Vasut
2013-10-27 18:26 ` Sourav Poddar
2013-10-27 18:30 ` Marek Vasut
2013-10-27 18:37 ` Sourav Poddar
2013-10-27 18:47 ` Marek Vasut
2013-10-29 5:57 ` Sourav Poddar
2013-10-29 14:01 ` Marek Vasut
2013-10-29 14:08 ` Sourav Poddar
2013-10-29 15:27 ` Marek Vasut
2013-10-29 16:52 ` Sourav Poddar
2013-10-29 17:08 ` Marek Vasut
2013-10-29 17:12 ` Sourav Poddar
2013-10-29 18:24 ` Marek Vasut
2013-10-29 18:34 ` Sourav Poddar
2013-10-30 6:27 ` Huang Shijie
2013-10-30 6:46 ` Sourav Poddar
2013-10-30 6:54 ` Huang Shijie
2013-10-30 10:11 ` Marek Vasut
2013-11-12 18:13 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52427A9F.9070107@ti.com \
--to=sourav.poddar@ti.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=b32955@freescale.com \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.