All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Hemant <hkshaw@linux.vnet.ibm.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
	linux-kernel@vger.kernel.org, srikar@linux.vnet.ibm.com,
	peterz@infradead.org, oleg@redhat.com, mingo@redhat.com,
	anton@redhat.com, systemtap@sourceware.org
Subject: Re: [PATCH 1/2] SDT markers listing by perf
Date: Wed, 25 Sep 2013 17:45:23 +0900	[thread overview]
Message-ID: <5242A2A3.303@hitachi.com> (raw)
In-Reply-To: <52427CAE.8030600@linux.vnet.ibm.com>

(2013/09/25 15:03), Hemant wrote:
>>> I have one doubt here. Why do we need [ARG ...] in the syntax you
>>> specified? I believe these args are to fetched from the sdt notes'
>>> section of the elf of the executable/library. Or am I taking this in a
>>> wrong way and this suggested syntax is actually for the uprobe_events
>>> file in the tracing directory?
>> Hm, indeed. Since all the arguments of the marker is defined in sdt notes,
>> we actually don't need to specify each of them. However, other probe syntax
>> has those arguments. I'd like to keep the same syntax style in the
>> same command (action) for avoiding confusion.
> 
> Hmm, got it.
> 
>> I recommend this way; at the first step, we just find the marker address from
>> sdt. And next, we will make the argument available. And eventually,
>> it is better to introduce "$args" meta argument to fetch all the arguments
>> of the marker.
>>
>> At this point, we can do
>>
>> perf probe %foo:bar $args
> 
> So, at first step (ignoring the arguments), we can go with :
> perf probe %foo:bar

Right,

> And, once, the argument support is enabled (all the arguments will be
> fetched at the marker location), we can go with:
> perf probe %foo:bar $args

Correct ;). In my plan, $parms and $vars will be also introduced for
accessing all function parameters and local variables correspondingly.

Thank you!

-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com



  reply	other threads:[~2013-09-25  8:45 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03  7:36 [RFC PATCH 0/2] Perf support to SDT markers Hemant Kumar Shaw
2013-09-03  7:36 ` [PATCH 1/2] SDT markers listing by perf Hemant Kumar
2013-09-03  8:19   ` Hemant
2013-09-04  6:43     ` Namhyung Kim
2013-09-04 17:40       ` Hemant
2013-09-04  6:42   ` Namhyung Kim
2013-09-04  8:01     ` Masami Hiramatsu
2013-09-04 17:58       ` Hemant
2013-09-15 11:28       ` Hemant
2013-09-25  4:37         ` Masami Hiramatsu
2013-09-25  6:03           ` Hemant
2013-09-25  8:45             ` Masami Hiramatsu [this message]
2013-09-04 17:37     ` Hemant
2013-09-06  6:37       ` Namhyung Kim
2013-09-06  8:41         ` Hemant
2013-09-04  7:21   ` Masami Hiramatsu
2013-09-04 17:52     ` Hemant
2013-09-03  7:37 ` [PATCH 2/2] Support to perf to probe on SDT markers: Hemant Kumar
2013-09-03  9:14   ` Masami Hiramatsu
2013-09-04  7:00   ` Namhyung Kim
2013-09-04  8:10     ` Masami Hiramatsu
2013-09-04 18:00       ` Hemant
2013-09-04 17:50     ` Hemant
2013-09-03  8:25 ` [RFC PATCH 0/2] Perf support to SDT markers Ingo Molnar
2013-09-03  9:17   ` Masami Hiramatsu
2013-09-03 13:23     ` Hemant
2013-09-03 14:21       ` Ingo Molnar
2013-09-03 15:11         ` Mark Wielaard
2013-09-03 19:24           ` Ingo Molnar
2013-09-03 15:24         ` Hemant
2013-09-04  6:49       ` Namhyung Kim
2013-09-04  8:22         ` Masami Hiramatsu
2013-09-04  8:25         ` Mark Wielaard
2013-09-04  8:39           ` Masami Hiramatsu
2013-09-04 18:08             ` Hemant
2013-09-05  4:59               ` Masami Hiramatsu
2013-09-04 18:12           ` Hemant
2013-09-04 18:52             ` Mark Wielaard
2013-09-04 20:39               ` Hemant
2013-09-04 17:45         ` Hemant
2013-09-04  6:08 ` Namhyung Kim
2013-09-04 17:08   ` Hemant
2013-09-04 23:41 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5242A2A3.303@hitachi.com \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=anton@redhat.com \
    --cc=hkshaw@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.