From: Paolo Bonzini <pbonzini@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org, mtosatti@redhat.com
Subject: Re: [PATCH] KVM: VMX: do not check bit 12 of EPT violation exit qualification when undefined
Date: Wed, 25 Sep 2013 11:49:20 +0200 [thread overview]
Message-ID: <5242B1A0.5050904@redhat.com> (raw)
In-Reply-To: <20130925075822.GL17294@redhat.com>
Il 25/09/2013 09:58, Gleb Natapov ha scritto:
> Bit 12 is undefined in any of the following cases:
> - If the "NMI exiting" VM-execution control is 1 and the "virtual NMIs"
> VM-execution control is 0.
> - If the VM exit sets the valid bit in the IDT-vectoring information field
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index a1216de..0e06c1c4 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -5345,7 +5345,9 @@ static int handle_ept_violation(struct kvm_vcpu *vcpu)
> * There are errata that may cause this bit to not be set:
> * AAK134, BY25.
> */
> - if (exit_qualification & INTR_INFO_UNBLOCK_NMI)
> + if (!(to_vmx(vcpu)->idt_vectoring_info & VECTORING_INFO_VALID_MASK) &&
> + cpu_has_virtual_nmis() &&
> + exit_qualification & INTR_INFO_UNBLOCK_NMI)
> vmcs_set_bits(GUEST_INTERRUPTIBILITY_INFO, GUEST_INTR_STATE_NMI);
>
> gpa = vmcs_read64(GUEST_PHYSICAL_ADDRESS);
> --
> Gleb.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Applied to kvm/master, thanks.
Paolo
prev parent reply other threads:[~2013-09-25 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 7:58 [PATCH] KVM: VMX: do not check bit 12 of EPT violation exit qualification when undefined Gleb Natapov
2013-09-25 9:49 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5242B1A0.5050904@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.