From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 3/4] KVM: nVMX: Check all exceptions for intercept during delivery to L2 Date: Wed, 25 Sep 2013 16:22:48 +0200 Message-ID: <5242F1B8.6040506@redhat.com> References: <1380102696-25267-1-git-send-email-gleb@redhat.com> <1380102696-25267-4-git-send-email-gleb@redhat.com> <5242EC70.6010003@redhat.com> <20130925141948.GC30317@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mail-qa0-f53.google.com ([209.85.216.53]:43015 "EHLO mail-qa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755120Ab3IYOWe (ORCPT ); Wed, 25 Sep 2013 10:22:34 -0400 Received: by mail-qa0-f53.google.com with SMTP id k4so3482406qaq.12 for ; Wed, 25 Sep 2013 07:22:33 -0700 (PDT) In-Reply-To: <20130925141948.GC30317@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 25/09/2013 16:19, Gleb Natapov ha scritto: >>> > > -static int nested_pf_handled(struct kvm_vcpu *vcpu) >>> > > +static int nested_ex_handled(struct kvm_vcpu *vcpu, unsigned nr) >>> > > { >>> > > struct vmcs12 *vmcs12 = get_vmcs12(vcpu); >>> > > >>> > > - /* TODO: also check PFEC_MATCH/MASK, not just EB.PF. */ >> > >> > Just one more question, why drop this comment? It doesn't seem >> > incorrect in the particular case where nr == PF_VECTOR. > > I moved it to vmx_inject_page_fault_nested(). Ah, so if you test it there, you shouldn't get here unless the PFEC_MASK/MATCH matches. In the case of EPT, you run with L1 PFEC_MASK/MATCH so you do not need any check. Paolo