From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: patches@linaro.org, xen-devel@lists.xen.org,
andre.przywara@linaro.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH 1/2] xen/arm: Add support to load initrd in dom0
Date: Wed, 25 Sep 2013 16:48:16 +0100 [thread overview]
Message-ID: <524305C0.8000306@linaro.org> (raw)
In-Reply-To: <1380123860.4910.48.camel@kazak.uk.xensource.com>
On 09/25/2013 04:44 PM, Ian Campbell wrote:
> On Wed, 2013-09-25 at 16:36 +0100, Julien Grall wrote:
>
>> Right, what about?
>>
>> #define ALIGN_2MB(size) ((len) + ((1 << 20 - 1)) & (~((1 << 20) - 1))
>> new_size = ALIGN_2MB(dtb_size) + ALIGN_2MB(initrd_size)
>
> Hard to believe we don't have an ALIGN or ROUNDUP macro already in a
> common header! How about we move the one from device_tree.c somewhere
> more generic?
>
> We could also add #define MB(x) ((x)<<20) alongside the existing GB(x)?
>
I will send a patch for the both macro and update this patch.
--
Julien Grall
next prev parent reply other threads:[~2013-09-25 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 15:20 [PATCH 0/2] ARM: Support initrd loading Julien Grall
2013-09-16 15:20 ` [PATCH 1/2] xen/arm: Add support to load initrd in dom0 Julien Grall
2013-09-25 15:15 ` Ian Campbell
2013-09-25 15:23 ` Julien Grall
2013-09-25 15:30 ` Ian Campbell
2013-09-25 15:36 ` Julien Grall
2013-09-25 15:44 ` Ian Campbell
2013-09-25 15:48 ` Julien Grall [this message]
2013-09-16 15:20 ` [PATCH 2/2] xen/dts: Support Linux initrd DT bindings Julien Grall
2013-09-25 15:16 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524305C0.8000306@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=andre.przywara@linaro.org \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.