From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Sachin Kamat <sachin.kamat@linaro.org>, linux-iio@vger.kernel.org
Subject: Re: [PATCH Resend 00/32] iio: Introduce devm_iio_device_{register,unregister}
Date: Wed, 25 Sep 2013 18:30:26 +0200 [thread overview]
Message-ID: <52430FA2.9030903@metafoo.de> (raw)
In-Reply-To: <9b84c130-be02-477f-9cce-6b0b066d70f5@email.android.com>
On 09/25/2013 06:24 PM, Jonathan Cameron wrote:
>
>
> Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> With the conversion of iio drivers to use device managed APIs, several
>> drivers now have a remove function with only the
>> iio_device_unregister()
>> call. Thus introduce device managed version of iio_device_register() to
>> clean up lot of such code. 3 patches also removes the unregister call
>> in drivers
>> where it happens to be the last call before return statement.
>>
>> This is only compile tested as I do not have any actual hardware to
>> test ATM.
>
> Hi all.
>
> I definitely want to gather opinions on this idea.
> It makes me nervous but the stats speak for themselves.
Same here.
>
> Jonathan
>>
>> Sachin Kamat (32):
>> iio: core: Implement devm_iio_device_{register,unregister}
>> iio: accel: kxsd9: Use devm_iio_device_register
>> iio: adc: mcp3422: Use devm_iio_device_register
>> iio: adc: twl6030-gpadc: Use devm_iio_device_register
>> iio: adc: viperboard: Use devm_iio_device_register
>> iio: dac: ad5421: Use devm_iio_device_register
>> iio: dac: ad5755: Use devm_iio_device_register
>> iio: dac: max517: Use devm_iio_device_register
>> iio: dac: mcp4725: Use devm_iio_device_register
>> iio: gyro: adis16130: Use devm_iio_device_register
>> iio: gyro: adxrs450: Use devm_iio_device_register
>> iio: light: vcnl4000: Use devm_iio_device_register
>> staging: iio: adis16220: Use devm_iio_device_register
>> staging: iio: ad7816: Use devm_iio_device_register
>> staging: iio: lpc32xx_adc: Use devm_iio_device_register
>> staging: iio: addac: Use devm_iio_device_register
>> staging: iio: ad7150: Use devm_iio_device_register
>> staging: iio: ad7746: Use devm_iio_device_register
>> staging: iio: ad5930: Use devm_iio_device_register
>> staging: iio: ad9850: Use devm_iio_device_register
>> staging: iio: ad9852: Use devm_iio_device_register
>> staging: iio: ad9910: Use devm_iio_device_register
>> staging: iio: ad9951: Use devm_iio_device_register
>> staging: iio: adis16060: Use devm_iio_device_register
>> staging: iio: isl29018: Use devm_iio_device_register
>> staging: iio: isl29028: Use devm_iio_device_register
>> staging: iio: tsl2583: Use devm_iio_device_register
>> staging: iio: tsl2x7x_core: Use devm_iio_device_register
>> staging: iio: ade7854: Use devm_iio_device_register
>> staging: iio: ad2s1200: Use devm_iio_device_register
>> staging: iio: ad2s90: Use devm_iio_device_register
>> staging: iio: ad7152: Use devm_iio_device_register
>>
>> Documentation/driver-model/devres.txt | 2 ++
>> drivers/iio/accel/kxsd9.c | 10 +-------
>> drivers/iio/adc/mcp3422.c | 9 +------
>> drivers/iio/adc/twl6030-gpadc.c | 5 +---
>> drivers/iio/adc/viperboard_adc.c | 12 +---------
>> drivers/iio/dac/ad5421.c | 12 +---------
>> drivers/iio/dac/ad5755.c | 12 +---------
>> drivers/iio/dac/max517.c | 9 +------
>> drivers/iio/dac/mcp4725.c | 9 +------
>> drivers/iio/gyro/adis16130.c | 9 +------
>> drivers/iio/gyro/adxrs450.c | 14 ++---------
>> drivers/iio/industrialio-core.c | 35
>> ++++++++++++++++++++++++++++
>> drivers/iio/light/vcnl4000.c | 9 +------
>> drivers/staging/iio/accel/adis16220_core.c | 7 ++----
>> drivers/staging/iio/adc/ad7816.c | 12 +---------
>> drivers/staging/iio/adc/lpc32xx_adc.c | 12 +---------
>> drivers/staging/iio/addac/adt7316-i2c.c | 6 -----
>> drivers/staging/iio/addac/adt7316-spi.c | 6 -----
>> drivers/staging/iio/addac/adt7316.c | 12 +---------
>> drivers/staging/iio/addac/adt7316.h | 1 -
>> drivers/staging/iio/cdc/ad7150.c | 12 +---------
>> drivers/staging/iio/cdc/ad7152.c | 12 +---------
>> drivers/staging/iio/cdc/ad7746.c | 12 +---------
>> drivers/staging/iio/frequency/ad5930.c | 10 +-------
>> drivers/staging/iio/frequency/ad9850.c | 10 +-------
>> drivers/staging/iio/frequency/ad9852.c | 10 +-------
>> drivers/staging/iio/frequency/ad9910.c | 10 +-------
>> drivers/staging/iio/frequency/ad9951.c | 10 +-------
>> drivers/staging/iio/gyro/adis16060_core.c | 10 +-------
>> drivers/staging/iio/light/isl29018.c | 13 +----------
>> drivers/staging/iio/light/isl29028.c | 11 +--------
>> drivers/staging/iio/light/tsl2583.c | 10 +-------
>> drivers/staging/iio/light/tsl2x7x_core.c | 4 +---
>> drivers/staging/iio/meter/ade7854-i2c.c | 6 -----
>> drivers/staging/iio/meter/ade7854-spi.c | 7 ------
>> drivers/staging/iio/meter/ade7854.c | 14 +----------
>> drivers/staging/iio/meter/ade7854.h | 1 -
>> drivers/staging/iio/resolver/ad2s1200.c | 10 +-------
>> drivers/staging/iio/resolver/ad2s90.c | 10 +-------
>> include/linux/iio/iio.h | 25 ++++++++++++++++++++
>> 40 files changed, 95 insertions(+), 315 deletions(-)
>
prev parent reply other threads:[~2013-09-25 16:30 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 10:49 [PATCH Resend 00/32] iio: Introduce devm_iio_device_{register,unregister} Sachin Kamat
2013-09-25 10:49 ` [PATCH 01/32] iio: core: Implement devm_iio_device_{register,unregister} Sachin Kamat
2013-09-26 20:31 ` Lars-Peter Clausen
2013-09-27 3:07 ` Sachin Kamat
2013-09-25 10:49 ` [PATCH 02/32] iio: accel: kxsd9: Use devm_iio_device_register Sachin Kamat
2013-09-25 20:45 ` Jonathan Cameron
2013-09-25 10:49 ` [PATCH 03/32] iio: adc: mcp3422: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 04/32] iio: adc: twl6030-gpadc: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 05/32] iio: adc: viperboard: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 06/32] iio: dac: ad5421: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 07/32] iio: dac: ad5755: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 08/32] iio: dac: max517: " Sachin Kamat
2013-09-25 21:00 ` Jonathan Cameron
2013-09-25 10:49 ` [PATCH 09/32] iio: dac: mcp4725: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 10/32] iio: gyro: adis16130: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 11/32] iio: gyro: adxrs450: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 12/32] iio: light: vcnl4000: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 13/32] staging: iio: adis16220: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 14/32] staging: iio: ad7816: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 15/32] staging: iio: lpc32xx_adc: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 16/32] staging: iio: addac: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 17/32] staging: iio: ad7150: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 18/32] staging: iio: ad7746: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 19/32] staging: iio: ad5930: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 20/32] staging: iio: ad9850: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 21/32] staging: iio: ad9852: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 22/32] staging: iio: ad9910: " Sachin Kamat
2013-09-25 10:49 ` [PATCH 23/32] staging: iio: ad9951: " Sachin Kamat
2013-09-25 10:50 ` [PATCH 24/32] staging: iio: adis16060: " Sachin Kamat
2013-09-25 10:50 ` [PATCH 25/32] staging: iio: isl29018: " Sachin Kamat
2013-09-25 10:50 ` [PATCH 26/32] staging: iio: isl29028: " Sachin Kamat
2013-09-25 10:50 ` [PATCH 27/32] staging: iio: tsl2583: " Sachin Kamat
2013-09-25 10:50 ` [PATCH 28/32] staging: iio: tsl2x7x_core: " Sachin Kamat
2013-09-25 16:32 ` Jonathan Cameron
2013-09-25 10:50 ` [PATCH 29/32] staging: iio: ade7854: " Sachin Kamat
2013-09-25 10:50 ` [PATCH 30/32] staging: iio: ad2s1200: " Sachin Kamat
2013-09-25 10:50 ` [PATCH 31/32] staging: iio: ad2s90: " Sachin Kamat
2013-09-25 10:50 ` [PATCH 32/32] staging: iio: ad7152: " Sachin Kamat
2013-09-25 16:24 ` [PATCH Resend 00/32] iio: Introduce devm_iio_device_{register,unregister} Jonathan Cameron
2013-09-25 16:30 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52430FA2.9030903@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.