Re: [PATCH] slab+rt: Don't free locks twice in cpuup_canceled

[Corey Minyard <cminyard@caviumnetworks.com>]

I forgot to mention that this was on 3.10.10-rt7.

-corey

On 09/20/2013 01:02 PM, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> Signed-off-by: Corey Minyard <cminyard@cavium.com>
> ---
>  mm/slab.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index 494274e..0a3d6d3 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -1270,7 +1270,6 @@ static void __cpuinit cpuup_canceled(long cpu)
>  			free_block(cachep, nc->entry, nc->avail, node);
>  
>  		if (!cpumask_empty(mask)) {
> -			local_spin_unlock_irq(slab_lock, &n->list_lock);
>  			unlock_l3_and_free_delayed(&n->list_lock);
>  			goto free_array_cache;
>  		}
> @@ -1285,7 +1284,6 @@ static void __cpuinit cpuup_canceled(long cpu)
>  		alien = n->alien;
>  		n->alien = NULL;
>  
> -		local_spin_unlock_irq(slab_lock, &n->list_lock);
>  		unlock_l3_and_free_delayed(&n->list_lock);
>  
>  		kfree(shared);