All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <nikolay@redhat.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, andy@greyhouse.net, fubar@us.ibm.com,
	eric.dumazet@gmail.com, vfalico@redhat.com
Subject: Re: [PATCH net-next v2 0/3] bonding: modify the current and add new hash functions
Date: Thu, 26 Sep 2013 01:56:41 +0200	[thread overview]
Message-ID: <52437839.70707@redhat.com> (raw)
In-Reply-To: <1380133912-1240-1-git-send-email-nikolay@redhat.com>

Self-nack on this patchset as the flow_dissector patch will make nhoff
different from before, that is the port offset will not be added to it, and
thus will make flow_keys' th_off different in skb_flow_dissect.
Again, I will wait until tomorrow to see if there're any other comments and
will re-post a v3 with this bug fixed.

Nik

      parent reply	other threads:[~2013-09-25 23:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-25 18:31 [PATCH net-next v2 0/3] bonding: modify the current and add new hash functions Nikolay Aleksandrov
2013-09-25 18:31 ` [PATCH net-next v2 1/3] flow_dissector: factor out the ports extraction in skb_flow_get_ports Nikolay Aleksandrov
2013-09-25 23:40   ` Nikolay Aleksandrov
2013-09-25 23:50     ` Nikolay Aleksandrov
2013-09-25 18:31 ` [PATCH net-next v2 2/3] bonding: modify the old and add new xmit hash policies Nikolay Aleksandrov
2013-09-25 18:31 ` [PATCH net-next v2 3/3] bonding: document the new xmit policy modes and update the changed ones Nikolay Aleksandrov
2013-09-25 23:56 ` Nikolay Aleksandrov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52437839.70707@redhat.com \
    --to=nikolay@redhat.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=fubar@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=vfalico@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.