From: Richard Weinberger <richard@nod.at>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org, dedekind1@gmail.com
Subject: Re: [PATCH 1/2] UBI: Fix error path in scan_pool()
Date: Thu, 26 Sep 2013 09:24:32 +0200 [thread overview]
Message-ID: <5243E130.3040200@nod.at> (raw)
In-Reply-To: <5243E033.7010403@gmail.com>
Am 26.09.2013 09:20, schrieb Richard Genoud:
> On 25/09/2013 22:32, Richard Weinberger wrote:
>> We have to set "ret", not "err" in case of an error.
>>
>> Reported-by: Richard Genoud <richard.genoud@gmail.com>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>> drivers/mtd/ubi/fastmap.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
>> index f5aa4b0..9b42add 100644
>> --- a/drivers/mtd/ubi/fastmap.c
>> +++ b/drivers/mtd/ubi/fastmap.c
>> @@ -428,7 +428,7 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai,
>> if (be32_to_cpu(ech->image_seq) != ubi->image_seq) {
>> ubi_err("bad image seq: 0x%x, expected: 0x%x",
>> be32_to_cpu(ech->image_seq), ubi->image_seq);
>> - err = UBI_BAD_FASTMAP;
>> + ret = UBI_BAD_FASTMAP;
>> goto out;
>> }
>>
>>
>
> Tested-by: Richard Genoud <richard.genoud@gmail.com>
>
> It reveals another bug though.
>
> [ 0.812500] UBI: default fastmap pool size: 95
> [ 0.820312] UBI: default fastmap WL pool size: 25
> [ 0.820312] UBI: attaching mtd2 to ubi0
> [ 0.914062] UBI error: scan_pool: bad image seq: 0x0, expected: 0x352a9728
This worries me more...
The fastmap is corrupted, now we have to find out why.
Broken driver? Powercut? IO errors?
> [ 0.921875] UBI error: ubi_scan_fastmap: Attach by fastmap failed, doing a full scan!
> [ 0.929687] kmem_cache_destroy ubi_ainf_peb_slab: Slab cache still has objects
I see.
Thanks,
//richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: dedekind1@gmail.com, dwmw2@infradead.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] UBI: Fix error path in scan_pool()
Date: Thu, 26 Sep 2013 09:24:32 +0200 [thread overview]
Message-ID: <5243E130.3040200@nod.at> (raw)
In-Reply-To: <5243E033.7010403@gmail.com>
Am 26.09.2013 09:20, schrieb Richard Genoud:
> On 25/09/2013 22:32, Richard Weinberger wrote:
>> We have to set "ret", not "err" in case of an error.
>>
>> Reported-by: Richard Genoud <richard.genoud@gmail.com>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>> drivers/mtd/ubi/fastmap.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
>> index f5aa4b0..9b42add 100644
>> --- a/drivers/mtd/ubi/fastmap.c
>> +++ b/drivers/mtd/ubi/fastmap.c
>> @@ -428,7 +428,7 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai,
>> if (be32_to_cpu(ech->image_seq) != ubi->image_seq) {
>> ubi_err("bad image seq: 0x%x, expected: 0x%x",
>> be32_to_cpu(ech->image_seq), ubi->image_seq);
>> - err = UBI_BAD_FASTMAP;
>> + ret = UBI_BAD_FASTMAP;
>> goto out;
>> }
>>
>>
>
> Tested-by: Richard Genoud <richard.genoud@gmail.com>
>
> It reveals another bug though.
>
> [ 0.812500] UBI: default fastmap pool size: 95
> [ 0.820312] UBI: default fastmap WL pool size: 25
> [ 0.820312] UBI: attaching mtd2 to ubi0
> [ 0.914062] UBI error: scan_pool: bad image seq: 0x0, expected: 0x352a9728
This worries me more...
The fastmap is corrupted, now we have to find out why.
Broken driver? Powercut? IO errors?
> [ 0.921875] UBI error: ubi_scan_fastmap: Attach by fastmap failed, doing a full scan!
> [ 0.929687] kmem_cache_destroy ubi_ainf_peb_slab: Slab cache still has objects
I see.
Thanks,
//richard
next prev parent reply other threads:[~2013-09-26 7:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 20:32 [PATCH 1/2] UBI: Fix error path in scan_pool() Richard Weinberger
2013-09-25 20:32 ` Richard Weinberger
2013-09-25 20:32 ` [PATCH 2/2] UBI: Call scan_all() with correct offset in error case Richard Weinberger
2013-09-25 20:32 ` Richard Weinberger
2013-09-26 7:22 ` Richard Genoud
2013-09-26 7:22 ` Richard Genoud
2013-09-26 7:20 ` [PATCH 1/2] UBI: Fix error path in scan_pool() Richard Genoud
2013-09-26 7:20 ` Richard Genoud
2013-09-26 7:24 ` Richard Weinberger [this message]
2013-09-26 7:24 ` Richard Weinberger
2013-09-26 7:33 ` Richard Genoud
2013-09-26 7:33 ` Richard Genoud
2013-09-26 9:25 ` Richard Genoud
2013-09-26 9:25 ` Richard Genoud
2013-09-26 9:59 ` Richard Weinberger
2013-09-26 9:59 ` Richard Weinberger
2013-09-27 11:01 ` Richard Weinberger
2013-09-27 11:01 ` Richard Weinberger
2013-09-27 11:12 ` Richard Genoud
2013-09-27 11:12 ` Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5243E130.3040200@nod.at \
--to=richard@nod.at \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.