From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH] clockevent: exynos_mct: fix lockdep warning Date: Thu, 26 Sep 2013 12:54:27 +0200 Message-ID: <52441263.8010507@linaro.org> References: <1380120578-17458-1-git-send-email-tom.leiming@gmail.com> <5243823D.4040208@linaro.org> <17472486.7GQJa9ux9F@amdc1227> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wi0-f171.google.com ([209.85.212.171]:49629 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756020Ab3IZKyd (ORCPT ); Thu, 26 Sep 2013 06:54:33 -0400 Received: by mail-wi0-f171.google.com with SMTP id hm2so6836563wib.16 for ; Thu, 26 Sep 2013 03:54:32 -0700 (PDT) In-Reply-To: <17472486.7GQJa9ux9F@amdc1227> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Tomasz Figa Cc: Ming Lei , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Kukjin Kim , linux-samsung-soc@vger.kernel.org, Tomasz Figa On 09/26/2013 12:32 PM, Tomasz Figa wrote: > Hi Daniel, > > On Thursday 26 of September 2013 02:39:25 Daniel Lezcano wrote: >> On 09/25/2013 04:49 PM, Ming Lei wrote: >>> This patch moves request_irq() out of cpu notifier callback >>> to fix below lockdep warning: >>> >>> [ 0.249513] ------------[ cut here ]------------ >>> [ 0.249525] WARNING: CPU: 1 PID: 0 at kernel/lockdep.c:2740 lock= dep_trace_alloc+0xc8/0x10c() >>> [ 0.249534] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) >>> [ 0.249538] Modules linked in: >>> [ 0.249548] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 3.12.0-rc1= -next-20130923+ #338 >>> [ 0.249564] [] (unwind_backtrace+0x0/0xec) from [] (show_stack+0x20/0x24) >>> [ 0.249577] [] (show_stack+0x20/0x24) from [= ] (dump_stack+0x74/0xb4) >>> [ 0.249591] [] (dump_stack+0x74/0xb4) from [= ] (warn_slowpath_common+0x78/0x9c) >>> [ 0.249604] [] (warn_slowpath_common+0x78/0x9c) from [= ] (warn_slowpath_fmt+0x40/0x48) >>> [ 0.249615] [] (warn_slowpath_fmt+0x40/0x48) from [] (lockdep_trace_alloc+0xc8/0x10c) >>> [ 0.249626] [] (lockdep_trace_alloc+0xc8/0x10c) from [= ] (kmem_cache_alloc_trace+0x38/0x2 >>> 24) >>> [ 0.249638] [] (kmem_cache_alloc_trace+0x38/0x224) fro= m [] (request_threaded_irq+0x90/0x130) >>> [ 0.249651] [] (request_threaded_irq+0x90/0x130) from = [] (exynos4_local_timer_setup+0xdc/0x140) >>> [ 0.249663] [] (exynos4_local_timer_setup+0xdc/0x140) = from [] (exynos4_mct_cpu_notify+0x40/0xb0) >>> [ 0.249675] [] (exynos4_mct_cpu_notify+0x40/0xb0) from= [] (notifier_call_chain+0x48/0x78) >>> [ 0.249688] [] (notifier_call_chain+0x48/0x78) from [<= c004abb0>] (__raw_notifier_call_chain+0x24/0x2c) >>> [ 0.249700] [] (__raw_notifier_call_chain+0x24/0x2c) f= rom [] (__cpu_notify+0x3c/0x58) >>> [ 0.249713] [] (__cpu_notify+0x3c/0x58) from [] (cpu_notify+0x20/0x24) >>> [ 0.249725] [] (cpu_notify+0x20/0x24) from [= ] (notify_cpu_starting+0x58/0x60) >>> [ 0.249737] [] (notify_cpu_starting+0x58/0x60) from [<= c00143cc>] (secondary_start_kernel+0xec/0x13 >>> 8) >>> [ 0.249748] [] (secondary_start_kernel+0xec/0x138) fro= m [<40008664>] (0x40008664) >>> [ 0.249767] ---[ end trace 3406ff24bd97382e ]--- >>> >>> Cc: Daniel Lezcano >>> Cc: Thomas Gleixner >>> Cc: Kukjin Kim >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-samsung-soc@vger.kernel.org >>> Signed-off-by: Ming Lei >>> --- >> >> Tomasz, what do you think ? > > This is a fix that we may want to have, but it must be modified to ta= ke > my regression fix[1] into account. > > [1] clocksource: exynos_mct: Set IRQ affinity when the CPU goes onlin= e > http://thread.gmane.org/gmane.linux.kernel.samsung-soc/22511/focus=3D= 23418 Ok, as the clockevents fixes PR for 3.12-rc2 has already been sent, thi= s=20 patch will go to next round of fixes. --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Thu, 26 Sep 2013 12:54:27 +0200 Subject: [PATCH] clockevent: exynos_mct: fix lockdep warning In-Reply-To: <17472486.7GQJa9ux9F@amdc1227> References: <1380120578-17458-1-git-send-email-tom.leiming@gmail.com> <5243823D.4040208@linaro.org> <17472486.7GQJa9ux9F@amdc1227> Message-ID: <52441263.8010507@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/26/2013 12:32 PM, Tomasz Figa wrote: > Hi Daniel, > > On Thursday 26 of September 2013 02:39:25 Daniel Lezcano wrote: >> On 09/25/2013 04:49 PM, Ming Lei wrote: >>> This patch moves request_irq() out of cpu notifier callback >>> to fix below lockdep warning: >>> >>> [ 0.249513] ------------[ cut here ]------------ >>> [ 0.249525] WARNING: CPU: 1 PID: 0 at kernel/lockdep.c:2740 lockdep_trace_alloc+0xc8/0x10c() >>> [ 0.249534] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) >>> [ 0.249538] Modules linked in: >>> [ 0.249548] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 3.12.0-rc1-next-20130923+ #338 >>> [ 0.249564] [] (unwind_backtrace+0x0/0xec) from [] (show_stack+0x20/0x24) >>> [ 0.249577] [] (show_stack+0x20/0x24) from [] (dump_stack+0x74/0xb4) >>> [ 0.249591] [] (dump_stack+0x74/0xb4) from [] (warn_slowpath_common+0x78/0x9c) >>> [ 0.249604] [] (warn_slowpath_common+0x78/0x9c) from [] (warn_slowpath_fmt+0x40/0x48) >>> [ 0.249615] [] (warn_slowpath_fmt+0x40/0x48) from [] (lockdep_trace_alloc+0xc8/0x10c) >>> [ 0.249626] [] (lockdep_trace_alloc+0xc8/0x10c) from [] (kmem_cache_alloc_trace+0x38/0x2 >>> 24) >>> [ 0.249638] [] (kmem_cache_alloc_trace+0x38/0x224) from [] (request_threaded_irq+0x90/0x130) >>> [ 0.249651] [] (request_threaded_irq+0x90/0x130) from [] (exynos4_local_timer_setup+0xdc/0x140) >>> [ 0.249663] [] (exynos4_local_timer_setup+0xdc/0x140) from [] (exynos4_mct_cpu_notify+0x40/0xb0) >>> [ 0.249675] [] (exynos4_mct_cpu_notify+0x40/0xb0) from [] (notifier_call_chain+0x48/0x78) >>> [ 0.249688] [] (notifier_call_chain+0x48/0x78) from [] (__raw_notifier_call_chain+0x24/0x2c) >>> [ 0.249700] [] (__raw_notifier_call_chain+0x24/0x2c) from [] (__cpu_notify+0x3c/0x58) >>> [ 0.249713] [] (__cpu_notify+0x3c/0x58) from [] (cpu_notify+0x20/0x24) >>> [ 0.249725] [] (cpu_notify+0x20/0x24) from [] (notify_cpu_starting+0x58/0x60) >>> [ 0.249737] [] (notify_cpu_starting+0x58/0x60) from [] (secondary_start_kernel+0xec/0x13 >>> 8) >>> [ 0.249748] [] (secondary_start_kernel+0xec/0x138) from [<40008664>] (0x40008664) >>> [ 0.249767] ---[ end trace 3406ff24bd97382e ]--- >>> >>> Cc: Daniel Lezcano >>> Cc: Thomas Gleixner >>> Cc: Kukjin Kim >>> Cc: linux-arm-kernel at lists.infradead.org >>> Cc: linux-samsung-soc at vger.kernel.org >>> Signed-off-by: Ming Lei >>> --- >> >> Tomasz, what do you think ? > > This is a fix that we may want to have, but it must be modified to take > my regression fix[1] into account. > > [1] clocksource: exynos_mct: Set IRQ affinity when the CPU goes online > http://thread.gmane.org/gmane.linux.kernel.samsung-soc/22511/focus=23418 Ok, as the clockevents fixes PR for 3.12-rc2 has already been sent, this patch will go to next round of fixes. -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog