All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 5/9] xen: arm: implement arch/platform SMP and CPU initialisation framework
Date: Thu, 26 Sep 2013 15:06:11 +0100	[thread overview]
Message-ID: <52443F53.4030602@linaro.org> (raw)
In-Reply-To: <1380192556-30700-5-git-send-email-ian.campbell@citrix.com>

On 09/26/2013 11:49 AM, Ian Campbell wrote:
> +
> +static int vexpress_smp_init(void)
> +{
> +    void __iomem *sysflags;
> +
> +    sysflags = ioremap_nocache(V2M_SYS_MMIO_BASE, PAGE_SIZE);
> +    if ( !sysflags )
> +    {
> +        dprintk(XENLOG_ERR, "Unable to map vexpress MMIO\n");
> +        return -EFAULT;
> +    }
> +
> +    printk("Set SYS_FLAGS to %"PRIpaddr" (%p)\n",
> +           __pa(init_secondary), init_secondary);
> +    iowritel(sysflags + V2M_SYS_FLAGSCLR, ~0);
> +    iowritel(sysflags + V2M_SYS_FLAGSSET,
> +             __pa(init_secondary));

You need to replace iowritel by writel.
Otherwise:
Acked-by: Julien Grall <julien.grall@linaro.org>

-- 
Julien Grall

  parent reply	other threads:[~2013-09-26 14:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26 10:48 [PATCH v2 0/9] xen: arm: rework early bring up Ian Campbell
2013-09-26 10:49 ` [PATCH v2 1/9] xen: arm: Load xen under 4GB on 32-bit Ian Campbell
2013-09-26 10:49 ` [PATCH v2 2/9] xen: arm: Log the raw MIDR on boot Ian Campbell
2013-09-26 10:49 ` [PATCH v2 3/9] xen: arm: make sure we stay within the memory bank during mm setup Ian Campbell
2013-09-26 11:14   ` Julien Grall
2013-09-26 13:17   ` Tim Deegan
2013-09-26 10:49 ` [PATCH v2 4/9] xen: arm: add two new device tree helpers Ian Campbell
2013-09-26 10:49 ` [PATCH v2 5/9] xen: arm: implement arch/platform SMP and CPU initialisation framework Ian Campbell
2013-09-26 13:47   ` Tim Deegan
2013-09-26 14:06   ` Julien Grall [this message]
2013-09-26 14:12     ` Ian Campbell
2013-09-26 10:49 ` [PATCH v2 6/9] xen: arm: rewrite start of day page table and cpu bring up Ian Campbell
2013-09-26 12:59   ` Ian Campbell
2013-09-26 14:31     ` Tim Deegan
2013-09-26 10:49 ` [PATCH v2 7/9] xen: arm: use symbolic names for MPIDR bits Ian Campbell
2013-09-26 13:22   ` Tim Deegan
2013-09-26 13:35     ` Ian Campbell
2013-09-26 13:45       ` Tim Deegan
2013-09-26 10:49 ` [PATCH v2 8/9] xen: arm: configure TCR_EL2 for 40 bit physical address space Ian Campbell
2013-09-26 10:49 ` [PATCH v2 9/9] xen: arm: split cpu0's domheap mapping PTs out from xen_second Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52443F53.4030602@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.