From: Richard Henderson <rth@twiddle.net>
To: Nathan Froyd <froydnj@mozilla.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, froydnj@gmail.com
Subject: Re: [Qemu-devel] [PATCH] target-i386: fix translation of sse {, u}comis{s, d} instructions
Date: Thu, 26 Sep 2013 07:15:49 -0700 [thread overview]
Message-ID: <52444195.30203@twiddle.net> (raw)
In-Reply-To: <E1VOwIk-0006Fg-4Z@eggs.gnu.org>
On 09/25/2013 01:20 PM, Nathan Froyd wrote:
> While the generic SSE translation codepath contains special logic to use
> 32-bit or 64-bit memory operands for some instructions, this logic doesn't
> catch the SSE {,u}comis{s,d} instructions. This oversight leads to too
> many bytes being read when those instructions use memory operands, which
> can in turn lead to page faults.
>
> The fix is simple: add a special case for these instructions. It did not
> fit cleanly into the existing case, so some cut-and-paste was necesary.
>
> Signed-off-by: Nathan Froyd <froydnj@mozilla.com>
> ---
> target-i386/translate.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
prev parent reply other threads:[~2013-09-26 14:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 20:20 [Qemu-devel] [PATCH] target-i386: fix translation of sse {, u}comis{s, d} instructions Nathan Froyd
2013-09-26 14:15 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52444195.30203@twiddle.net \
--to=rth@twiddle.net \
--cc=froydnj@gmail.com \
--cc=froydnj@mozilla.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.