From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VPCuQ-0005gG-VX for mharc-qemu-trivial@gnu.org; Thu, 26 Sep 2013 10:51:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPCuJ-0005dm-LI for qemu-trivial@nongnu.org; Thu, 26 Sep 2013 10:51:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPCuF-0002Wu-2Q for qemu-trivial@nongnu.org; Thu, 26 Sep 2013 10:51:07 -0400 Received: from mel.act-europe.fr ([194.98.77.210]:47491 helo=smtp.eu.adacore.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPCu4-0002Uq-Ts; Thu, 26 Sep 2013 10:50:53 -0400 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 95A3D2682FD7; Thu, 26 Sep 2013 16:50:51 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1zxio3b6JjcK; Thu, 26 Sep 2013 16:50:51 +0200 (CEST) Received: from [10.10.1.88] (pompomgalli.act-europe.fr [10.10.1.88]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 7BCCC2682FAB; Thu, 26 Sep 2013 16:50:51 +0200 (CEST) Message-ID: <524449CA.5080706@adacore.com> Date: Thu, 26 Sep 2013 16:50:50 +0200 From: Fabien Chouteau User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Peter Maydell References: <1380041161-13266-1-git-send-email-chouteau@adacore.com> <1380041161-13266-4-git-send-email-chouteau@adacore.com> <5243035D.4080200@adacore.com> <52430F79.6050202@adacore.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 194.98.77.210 Cc: QEMU Trivial , Luiz Capitulino , QEMU Developers , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/3] Add ARM registers definitions in Monitor commands X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Sep 2013 14:51:12 -0000 On 09/26/2013 02:05 AM, Peter Maydell wrote: > On 26 September 2013 01:29, Fabien Chouteau wrote: >> On 09/25/2013 05:51 PM, Peter Maydell wrote: >>> On 26 September 2013 00:38, Fabien Chouteau wrote: >>> It doesn't matter very much, but monitor.h seems the obvious >>> place. You probably don't want qom/cpu.h to have to drag in >>> monitor.h so a 'struct MonitorDef;' forward declaration in cpu.h >>> will let you avoid that (we do that already for a few other structs). >> >> I think that's what I did. I think the problem was to include >> 'monitor.h' in 'target-*/cpu.c'. > > Why doesn't that work? > The problem is use of 'target_long' in 'monitor.h'. -- Fabien Chouteau From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPCuA-0005Zw-3N for qemu-devel@nongnu.org; Thu, 26 Sep 2013 10:51:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPCu5-0002V6-7O for qemu-devel@nongnu.org; Thu, 26 Sep 2013 10:50:58 -0400 Message-ID: <524449CA.5080706@adacore.com> Date: Thu, 26 Sep 2013 16:50:50 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1380041161-13266-1-git-send-email-chouteau@adacore.com> <1380041161-13266-4-git-send-email-chouteau@adacore.com> <5243035D.4080200@adacore.com> <52430F79.6050202@adacore.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] Add ARM registers definitions in Monitor commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Trivial , Luiz Capitulino , QEMU Developers , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= On 09/26/2013 02:05 AM, Peter Maydell wrote: > On 26 September 2013 01:29, Fabien Chouteau wrote: >> On 09/25/2013 05:51 PM, Peter Maydell wrote: >>> On 26 September 2013 00:38, Fabien Chouteau wrote: >>> It doesn't matter very much, but monitor.h seems the obvious >>> place. You probably don't want qom/cpu.h to have to drag in >>> monitor.h so a 'struct MonitorDef;' forward declaration in cpu.h >>> will let you avoid that (we do that already for a few other structs). >> >> I think that's what I did. I think the problem was to include >> 'monitor.h' in 'target-*/cpu.c'. > > Why doesn't that work? > The problem is use of 'target_long' in 'monitor.h'. -- Fabien Chouteau