All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 05/11] mtd: Build nand_util.o for CONFIG_ENV_IS_IN_NAND in SPL
Date: Thu, 26 Sep 2013 16:45:44 -0400	[thread overview]
Message-ID: <52449CF8.8050206@ti.com> (raw)
In-Reply-To: <1380228142.24959.302.camel@snotra.buserror.net>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/26/2013 04:42 PM, Scott Wood wrote:
> On Thu, 2013-09-26 at 16:28 -0400, Tom Rini wrote:
>> Cc: Scott Wood <scottwood@freescale.com>
>> Signed-off-by: Tom Rini <trini@ti.com>
>> ---
>>  drivers/mtd/nand/Makefile |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
>> index 366dee6..bb5b29d 100644
>> --- a/drivers/mtd/nand/Makefile
>> +++ b/drivers/mtd/nand/Makefile
>> @@ -24,6 +24,7 @@ COBJS-$(CONFIG_SPL_NAND_LOAD) += nand_spl_load.o
>>  COBJS-$(CONFIG_SPL_NAND_ECC) += nand_ecc.o
>>  COBJS-$(CONFIG_SPL_NAND_BASE) += nand_base.o
>>  COBJS-$(CONFIG_SPL_NAND_INIT) += nand.o
>> +COBJS-$(CONFIG_ENV_IS_IN_NAND) += nand_util.o
> 
> Not all NAND SPLs will want this.  Define a new CONFIG_SPL_* symbol, or
> perhaps it could just use CONFIG_SPL_NAND_BASE.

Then they won't get it.  Without CONFIG_SPL_ENV_SUPPORT that all gets
discarded.  And talked about before adding CONFIG_SPL_ENV_... and I
didn't want to go down that path.  If you feel strongly about not
building the object we can guard this with CONFIG_SPL_ENV_SUPPORT checks
perhaps?

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSRJz4AAoJENk4IS6UOR1WMfAP/RkD0fqs0QMaS+rXwrFtVSuk
D3wH9KmvehSgY8AL1rq/gpNxFSj/t3/yqdMP6uE1RIJQjlcMsAhXalsy9+QSzDeq
TInAA3gebJVOIJzvJlPEkaR4ybEdQOgtMzcWXqV0mrV626SXfNo6PQ8ZtGxBxAm3
oDBbJw0xkmkqnVgOy+jNDgoPoR8aNl1bbpB0UTb2Iz5rRghf0GYPVeR3J88+Fgtq
cm0sQdklkl28ZnbJFU9uhL7Sdws23QuZBihIwiEwmMqwT1pI17nF/YGm3WaayGd3
Pb4wb+FyesDHIcTwl4fDDN+QMNFQ6oz/3lden6X7a/rPHJWxxxUFQtKFykIfExk3
YnPMud20TDlEHeRvoI4vqqvtBd2/nCjyw/R2UhMgyc0Uk+43lJUbXhiq9XbLk88t
m5RZjsfLGTUl12Uxe5OIh+s8O1BkrmY+knyZSwy8uw0JZcnuuV11A15vNoCMNQzc
vzzXCke8r0rS5Ci3ai2R6XGJX8Thh3QD3+ZYED899B2TwPxHH6wo6saLnNNf4nYt
s41rExlhzCMDRSl3Kd1pnFIFu7butiRZWuRldTY/ASwAZKtvvUOibq9U23HtWwKY
JSLlkkTjIOEsJPZcvPgooMHdJA1Kyt5Lb9SHpgkozqd1Dy0WPA/JOSfgoGoSRhKh
tM0XMWkMuUYt1oNToTkl
=n9Vw
-----END PGP SIGNATURE-----

  reply	other threads:[~2013-09-26 20:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26 20:27 [U-Boot] [PATCH 00/11] NAND/MMC environment in SPL, Falcon Mode enhancements Tom Rini
2013-09-26 20:27 ` [U-Boot] [PATCH 01/11] fw_env.c: Increase max dev path to 32 Tom Rini
2013-10-05 20:02   ` Wolfgang Denk
2013-10-06 20:55     ` Tom Rini
2013-10-07  5:47       ` Wolfgang Denk
2013-10-07 12:06         ` Tom Rini
2013-09-26 20:27 ` [U-Boot] [PATCH 02/11] env_mmc.c: Make the non-redundant env_relocate_spec use malloc not stack Tom Rini
2013-10-05 20:00   ` Wolfgang Denk
2013-10-06 20:40     ` Tom Rini
2013-10-07  5:41       ` Wolfgang Denk
2013-09-26 20:27 ` [U-Boot] [PATCH 03/11] env_mmc.c: Allow environment to be used within SPL Tom Rini
2013-09-26 20:28 ` [U-Boot] [PATCH 04/11] mtd: Add a CONFIG_SPL_MTD_SUPPORT for a more full NAND subsystem in SPL Tom Rini
2013-09-26 20:39   ` Scott Wood
2013-09-26 20:28 ` [U-Boot] [PATCH 05/11] mtd: Build nand_util.o for CONFIG_ENV_IS_IN_NAND " Tom Rini
2013-09-26 20:42   ` Scott Wood
2013-09-26 20:45     ` Tom Rini [this message]
2013-09-26 20:51       ` Scott Wood
2013-09-26 21:14         ` Tom Rini
2013-09-26 20:28 ` [U-Boot] [PATCH 06/11] spl: Make CONFIG_SPL_ENV_SUPPORT have to be set by all users of env " Tom Rini
2013-09-26 20:28 ` [U-Boot] [PATCH 07/11] am335x_evm: Make SPL_OS also check the boot_os variable for falcon mode Tom Rini
2013-09-26 20:28 ` [U-Boot] [PATCH 08/11] README: Add CONFIG_SPL_OS_BOOT to README Tom Rini
2013-09-26 20:28 ` [U-Boot] [PATCH 09/11] README.falcon: Document environment variables for falcon mode Tom Rini
2013-09-26 20:28 ` [U-Boot] [PATCH 10/11] a3m071: Make spl_start_uboot test like getenv_yesno does Tom Rini
2013-09-27  7:04   ` Stefan Roese
2013-09-26 20:28 ` [U-Boot] [PATCH 11/11] spl_mmc/CONFIG_SPL_OS_BOOT: Allow environment to determine what to boot Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52449CF8.8050206@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.