From: Eric Sandeen <sandeen@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Carlos Maiolino <cmaiolino@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2image: Print a warning if running over a mounted filesystem
Date: Thu, 26 Sep 2013 19:39:30 -0500 [thread overview]
Message-ID: <5244D3C2.4090606@redhat.com> (raw)
In-Reply-To: <20130926235658.GD6011@thunk.org>
On 9/26/13 6:56 PM, Theodore Ts'o wrote:
> On Thu, Sep 26, 2013 at 06:00:04PM -0300, Carlos Maiolino wrote:
>> Several users use to run e2image over a mounted filesystem, providing
>> inconsistent, useless e2images.
>> This patch adds a warning in such cases, notifying the user and also adds a
>> force option making e2image able to run over Read-only filesystems.
>
> It should be perfectly safe to run e2image on a read-only mounted file
> system option, so it's not obvious to me why the force option would be
> needed in that case.
right now Carlos' test isn't checking for readonly; just mounted, right?
But I think it should check for ro, and allow it by default in that case,
I agree.
> Also, if we are saving a "normal" (not a raw or qcow) e2image file, we
> are only backing up the statically located metadata blocks (i.e.,
> superblock, block group descriptors, inode table, and allocation
> bitmaps). If we do this on a mounted file system, the e2image file is
> less useful, but I'm not sure I'd call it completely useless. If the
> goal is to backup critical metadata, it will do that just fine. So
> maybe it's worthy of a warning, but I'm not sure it should require a
> force option.
I asked Carlos to do this after getting the 2nd customer filesystem
image in a week which was useless for triage due to having been run
on a live, mounted fs...
I fear that a warning would be ignored, but *shrug* - at least something
so we have some hope of getting something useful out the other end
of e2image -r or -Q...
TBH I've never used a "normal" image; if you want to allow it to
run on an RW filesystem that won't bother me at all. ;)
> If the user is trying to capture a raw or qcow image file, I agree
> that requiring that the file systme either be mounted read-only, not
> mounted at all, or that a force option be specified, makes sense.
cool. :)
-Eric
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-09-27 0:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 21:00 [PATCH] e2image: Print a warning if running over a mounted filesystem Carlos Maiolino
2013-09-26 22:12 ` Eric Sandeen
2013-09-26 23:56 ` Theodore Ts'o
2013-09-27 0:39 ` Eric Sandeen [this message]
2013-09-27 0:48 ` Carlos Maiolino
2013-09-30 20:19 ` Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2013-09-27 19:01 Carlos Maiolino
2013-09-27 20:00 ` Carlos Maiolino
2013-09-30 20:24 ` Theodore Ts'o
2013-09-30 20:35 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5244D3C2.4090606@redhat.com \
--to=sandeen@redhat.com \
--cc=cmaiolino@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.