From: Xuebing Wang <xbing6@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>
Cc: linux-wireless@vger.kernel.org
Subject: RTL8192CU: about trivial change of removing some 8192c declaration from header file
Date: Mon, 26 Sep 2016 09:55:39 +0800 [thread overview]
Message-ID: <5244f149-9792-e814-7ee2-0a3fd178d306@gmail.com> (raw)
Hi Larry and Chaoming:
I am trying to do User Mode driver for RTL8192CU (device is Alfa
AWUS036NHR which is 802.11 b/g/n), and I am reading RTL8192CU / RTL8192C
/ RTLWIFI driver source code.
There is a very trivial error that below declarations (in
rtl8192cu/hw.h) are already in file
drivers/net/wireless/realtek/rtlwifi/rtl8192c/fw_common.h
---
int rtl92c_download_fw(struct ieee80211_hw *hw);
void rtl92c_set_fw_pwrmode_cmd(struct ieee80211_hw *hw, u8 mode);
void rtl92c_set_fw_joinbss_report_cmd(struct ieee80211_hw *hw, u8 mstatus);
void rtl92c_fill_h2c_cmd(struct ieee80211_hw *hw,
u8 element_id, u32 cmd_len, u8 *p_cmdbuffer);
---
Does it make sense for me to submit a trivial patch to remove these
declarations from rtl8192cu/hw.h?
Thanks.
xuebing
reply other threads:[~2016-09-26 1:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5244f149-9792-e814-7ee2-0a3fd178d306@gmail.com \
--to=xbing6@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.