From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCHv4 11/18] arm: dts: add omap4430 thermal data Date: Fri, 27 Sep 2013 09:42:49 -0400 Message-ID: <52458B59.8070703@ti.com> References: <1380251605-3804-1-git-send-email-eduardo.valentin@ti.com> <1380251605-3804-12-git-send-email-eduardo.valentin@ti.com> <20130927122439.GA8360@kahuna> <5245861F.7000109@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1152409969966347977==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Nishanth Menon Cc: Mark Rutland , dt list , wni@nvidia.com, durgadoss.r@intel.com, Ian Campbell , Pawel Moll , Stephen Warren , Tony Lindgren , devicetree-discuss@lists.ozlabs.org, linux-pm@vger.kernel.org, lkml , Rob Herring , lm-sensors@lm-sensors.org, Eduardo Valentin , linux@roeck-us.net, =?ISO-8859-1?Q?Beno=EEt_Cousson?= , Grant Likely , Russell King , rui.zhang@intel.com, linux-omap , "linux-arm-kernel@lists.infradead.org" List-Id: linux-omap@vger.kernel.org --===============1152409969966347977== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="okDvHLNIenjhDREDRe2cvg6qUKECOqodL" --okDvHLNIenjhDREDRe2cvg6qUKECOqodL Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 27-09-2013 09:26, Nishanth Menon wrote: > On Fri, Sep 27, 2013 at 8:20 AM, Eduardo Valentin > wrote: >> On 27-09-2013 08:24, Nishanth Menon wrote: >>> On 23:13-20130926, Eduardo Valentin wrote: >>>> This patch changes the dtsi entry on omap4430 to contain >>>> the thermal data. This data will enable the passive >>>> cooling with CPUfreq cooling device at 100C and the >>>> system will do a thermal shutdown at 125C. >>>> >>>> Cc: "Beno=EEt Cousson" >>>> Cc: Tony Lindgren >>>> Cc: Russell King >>>> Cc: linux-omap@vger.kernel.org >>>> Cc: devicetree-discuss@lists.ozlabs.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-kernel@vger.kernel.org >>>> Signed-off-by: Eduardo Valentin >>>> --- >>>> arch/arm/boot/dts/omap443x.dtsi | 10 ++++++++-- >>>> 1 file changed, 8 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/oma= p443x.dtsi >>>> index bcf455e..e9c97d6 100644 >>>> --- a/arch/arm/boot/dts/omap443x.dtsi >>>> +++ b/arch/arm/boot/dts/omap443x.dtsi >>>> @@ -12,7 +12,7 @@ >>>> >>>> / { >>>> cpus { >>>> - cpu@0 { >>>> + cpu0: cpu@0 { >>>> /* OMAP443x variants OPP50-OPPNT */ >>>> operating-points =3D < >>>> /* kHz uV */ >>>> @@ -25,9 +25,15 @@ >>>> }; >>>> }; >>>> >>>> - bandgap { >>>> + thermal-zones{ >>>> + #include "omap4-cpu-thermal.dtsi" >>>> + }; >>>> + >>>> + bandgap: bandgap { >>>> reg =3D <0x4a002260 0x4 >>>> 0x4a00232C 0x4>; >>>> compatible =3D "ti,omap4430-bandgap"; >>>> + >>>> + #thermal-sensor-cells =3D <0>; >>> 2 cents: >>> we might want to move bandgap under ocp? >>> >> >> Yes, agreed. But I don't think this change is related to this patch or= >> to this series. >=20 > Correct - this comment is not related to the current patch, hence my 2 > cents ;) - will be nice to have it cleaned up though.. Yes, it will be cleaned. ;-) Tks. >=20 > Regards, > Nishanth Menon >=20 >=20 --=20 You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin --okDvHLNIenjhDREDRe2cvg6qUKECOqodL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlJFi1kACgkQCXcVR3XQvP0QoAEA4MfbQt5xnfzUFjwU/nzb4Ahg nKZcdTIocqE6yVs/mg0A+wejPt8TOxTb8Gxy4/HJfD3MgfnLul13qlpnMBWID75d =J34r -----END PGP SIGNATURE----- --okDvHLNIenjhDREDRe2cvg6qUKECOqodL-- --===============1152409969966347977== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1152409969966347977==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Date: Fri, 27 Sep 2013 13:42:49 +0000 Subject: Re: [lm-sensors] [PATCHv4 11/18] arm: dts: add omap4430 thermal data Message-Id: <52458B59.8070703@ti.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============5394010357316513761==" List-Id: References: <1380251605-3804-1-git-send-email-eduardo.valentin@ti.com> <1380251605-3804-12-git-send-email-eduardo.valentin@ti.com> <20130927122439.GA8360@kahuna> <5245861F.7000109@ti.com> In-Reply-To: To: Nishanth Menon Cc: Eduardo Valentin , Mark Rutland , dt list , wni@nvidia.com, durgadoss.r@intel.com, Ian Campbell , Pawel Moll , Stephen Warren , Tony Lindgren , devicetree-discuss@lists.ozlabs.org, linux-pm@vger.kernel.org, lkml , Rob Herring , lm-sensors@lm-sensors.org, "linux-arm-kernel@lists.infradead.org" , =?ISO-8859-1?Q?Beno=EEt_Cousson?= , Grant Likely , Russell King , rui.zhang@intel.com, linux-omap , linux@roeck-us.net --===============5394010357316513761== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="okDvHLNIenjhDREDRe2cvg6qUKECOqodL" --okDvHLNIenjhDREDRe2cvg6qUKECOqodL Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 27-09-2013 09:26, Nishanth Menon wrote: > On Fri, Sep 27, 2013 at 8:20 AM, Eduardo Valentin > wrote: >> On 27-09-2013 08:24, Nishanth Menon wrote: >>> On 23:13-20130926, Eduardo Valentin wrote: >>>> This patch changes the dtsi entry on omap4430 to contain >>>> the thermal data. This data will enable the passive >>>> cooling with CPUfreq cooling device at 100C and the >>>> system will do a thermal shutdown at 125C. >>>> >>>> Cc: "Beno=EEt Cousson" >>>> Cc: Tony Lindgren >>>> Cc: Russell King >>>> Cc: linux-omap@vger.kernel.org >>>> Cc: devicetree-discuss@lists.ozlabs.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-kernel@vger.kernel.org >>>> Signed-off-by: Eduardo Valentin >>>> --- >>>> arch/arm/boot/dts/omap443x.dtsi | 10 ++++++++-- >>>> 1 file changed, 8 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/oma= p443x.dtsi >>>> index bcf455e..e9c97d6 100644 >>>> --- a/arch/arm/boot/dts/omap443x.dtsi >>>> +++ b/arch/arm/boot/dts/omap443x.dtsi >>>> @@ -12,7 +12,7 @@ >>>> >>>> / { >>>> cpus { >>>> - cpu@0 { >>>> + cpu0: cpu@0 { >>>> /* OMAP443x variants OPP50-OPPNT */ >>>> operating-points =3D < >>>> /* kHz uV */ >>>> @@ -25,9 +25,15 @@ >>>> }; >>>> }; >>>> >>>> - bandgap { >>>> + thermal-zones{ >>>> + #include "omap4-cpu-thermal.dtsi" >>>> + }; >>>> + >>>> + bandgap: bandgap { >>>> reg =3D <0x4a002260 0x4 >>>> 0x4a00232C 0x4>; >>>> compatible =3D "ti,omap4430-bandgap"; >>>> + >>>> + #thermal-sensor-cells =3D <0>; >>> 2 cents: >>> we might want to move bandgap under ocp? >>> >> >> Yes, agreed. But I don't think this change is related to this patch or= >> to this series. >=20 > Correct - this comment is not related to the current patch, hence my 2 > cents ;) - will be nice to have it cleaned up though.. Yes, it will be cleaned. ;-) Tks. >=20 > Regards, > Nishanth Menon >=20 >=20 --=20 You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin --okDvHLNIenjhDREDRe2cvg6qUKECOqodL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlJFi1kACgkQCXcVR3XQvP0QoAEA4MfbQt5xnfzUFjwU/nzb4Ahg nKZcdTIocqE6yVs/mg0A+wejPt8TOxTb8Gxy4/HJfD3MgfnLul13qlpnMBWID75d =J34r -----END PGP SIGNATURE----- --okDvHLNIenjhDREDRe2cvg6qUKECOqodL-- --===============5394010357316513761== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors --===============5394010357316513761==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: eduardo.valentin@ti.com (Eduardo Valentin) Date: Fri, 27 Sep 2013 09:42:49 -0400 Subject: [PATCHv4 11/18] arm: dts: add omap4430 thermal data In-Reply-To: References: <1380251605-3804-1-git-send-email-eduardo.valentin@ti.com> <1380251605-3804-12-git-send-email-eduardo.valentin@ti.com> <20130927122439.GA8360@kahuna> <5245861F.7000109@ti.com> Message-ID: <52458B59.8070703@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 27-09-2013 09:26, Nishanth Menon wrote: > On Fri, Sep 27, 2013 at 8:20 AM, Eduardo Valentin > wrote: >> On 27-09-2013 08:24, Nishanth Menon wrote: >>> On 23:13-20130926, Eduardo Valentin wrote: >>>> This patch changes the dtsi entry on omap4430 to contain >>>> the thermal data. This data will enable the passive >>>> cooling with CPUfreq cooling device at 100C and the >>>> system will do a thermal shutdown at 125C. >>>> >>>> Cc: "Beno?t Cousson" >>>> Cc: Tony Lindgren >>>> Cc: Russell King >>>> Cc: linux-omap at vger.kernel.org >>>> Cc: devicetree-discuss at lists.ozlabs.org >>>> Cc: linux-arm-kernel at lists.infradead.org >>>> Cc: linux-kernel at vger.kernel.org >>>> Signed-off-by: Eduardo Valentin >>>> --- >>>> arch/arm/boot/dts/omap443x.dtsi | 10 ++++++++-- >>>> 1 file changed, 8 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/omap443x.dtsi >>>> index bcf455e..e9c97d6 100644 >>>> --- a/arch/arm/boot/dts/omap443x.dtsi >>>> +++ b/arch/arm/boot/dts/omap443x.dtsi >>>> @@ -12,7 +12,7 @@ >>>> >>>> / { >>>> cpus { >>>> - cpu at 0 { >>>> + cpu0: cpu at 0 { >>>> /* OMAP443x variants OPP50-OPPNT */ >>>> operating-points = < >>>> /* kHz uV */ >>>> @@ -25,9 +25,15 @@ >>>> }; >>>> }; >>>> >>>> - bandgap { >>>> + thermal-zones{ >>>> + #include "omap4-cpu-thermal.dtsi" >>>> + }; >>>> + >>>> + bandgap: bandgap { >>>> reg = <0x4a002260 0x4 >>>> 0x4a00232C 0x4>; >>>> compatible = "ti,omap4430-bandgap"; >>>> + >>>> + #thermal-sensor-cells = <0>; >>> 2 cents: >>> we might want to move bandgap under ocp? >>> >> >> Yes, agreed. But I don't think this change is related to this patch or >> to this series. > > Correct - this comment is not related to the current patch, hence my 2 > cents ;) - will be nice to have it cleaned up though.. Yes, it will be cleaned. ;-) Tks. > > Regards, > Nishanth Menon > > -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 295 bytes Desc: OpenPGP digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754807Ab3I0Not (ORCPT ); Fri, 27 Sep 2013 09:44:49 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:43331 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752624Ab3I0Non (ORCPT ); Fri, 27 Sep 2013 09:44:43 -0400 Message-ID: <52458B59.8070703@ti.com> Date: Fri, 27 Sep 2013 09:42:49 -0400 From: Eduardo Valentin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Nishanth Menon CC: Eduardo Valentin , Mark Rutland , dt list , , , Ian Campbell , Pawel Moll , Stephen Warren , Tony Lindgren , , , lkml , Rob Herring , , "linux-arm-kernel@lists.infradead.org" , =?ISO-8859-1?Q?Beno=EEt_Cousson?= , Grant Likely , Russell King , , linux-omap , Subject: Re: [PATCHv4 11/18] arm: dts: add omap4430 thermal data References: <1380251605-3804-1-git-send-email-eduardo.valentin@ti.com> <1380251605-3804-12-git-send-email-eduardo.valentin@ti.com> <20130927122439.GA8360@kahuna> <5245861F.7000109@ti.com> In-Reply-To: X-Enigmail-Version: 1.5.2 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="okDvHLNIenjhDREDRe2cvg6qUKECOqodL" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --okDvHLNIenjhDREDRe2cvg6qUKECOqodL Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 27-09-2013 09:26, Nishanth Menon wrote: > On Fri, Sep 27, 2013 at 8:20 AM, Eduardo Valentin > wrote: >> On 27-09-2013 08:24, Nishanth Menon wrote: >>> On 23:13-20130926, Eduardo Valentin wrote: >>>> This patch changes the dtsi entry on omap4430 to contain >>>> the thermal data. This data will enable the passive >>>> cooling with CPUfreq cooling device at 100C and the >>>> system will do a thermal shutdown at 125C. >>>> >>>> Cc: "Beno=EEt Cousson" >>>> Cc: Tony Lindgren >>>> Cc: Russell King >>>> Cc: linux-omap@vger.kernel.org >>>> Cc: devicetree-discuss@lists.ozlabs.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-kernel@vger.kernel.org >>>> Signed-off-by: Eduardo Valentin >>>> --- >>>> arch/arm/boot/dts/omap443x.dtsi | 10 ++++++++-- >>>> 1 file changed, 8 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/oma= p443x.dtsi >>>> index bcf455e..e9c97d6 100644 >>>> --- a/arch/arm/boot/dts/omap443x.dtsi >>>> +++ b/arch/arm/boot/dts/omap443x.dtsi >>>> @@ -12,7 +12,7 @@ >>>> >>>> / { >>>> cpus { >>>> - cpu@0 { >>>> + cpu0: cpu@0 { >>>> /* OMAP443x variants OPP50-OPPNT */ >>>> operating-points =3D < >>>> /* kHz uV */ >>>> @@ -25,9 +25,15 @@ >>>> }; >>>> }; >>>> >>>> - bandgap { >>>> + thermal-zones{ >>>> + #include "omap4-cpu-thermal.dtsi" >>>> + }; >>>> + >>>> + bandgap: bandgap { >>>> reg =3D <0x4a002260 0x4 >>>> 0x4a00232C 0x4>; >>>> compatible =3D "ti,omap4430-bandgap"; >>>> + >>>> + #thermal-sensor-cells =3D <0>; >>> 2 cents: >>> we might want to move bandgap under ocp? >>> >> >> Yes, agreed. But I don't think this change is related to this patch or= >> to this series. >=20 > Correct - this comment is not related to the current patch, hence my 2 > cents ;) - will be nice to have it cleaned up though.. Yes, it will be cleaned. ;-) Tks. >=20 > Regards, > Nishanth Menon >=20 >=20 --=20 You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin --okDvHLNIenjhDREDRe2cvg6qUKECOqodL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlJFi1kACgkQCXcVR3XQvP0QoAEA4MfbQt5xnfzUFjwU/nzb4Ahg nKZcdTIocqE6yVs/mg0A+wejPt8TOxTb8Gxy4/HJfD3MgfnLul13qlpnMBWID75d =J34r -----END PGP SIGNATURE----- --okDvHLNIenjhDREDRe2cvg6qUKECOqodL--