Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up

[Julien Grall <julien.grall@linaro.org>]

On 09/27/2013 04:17 PM, Ian Campbell wrote:
> On Fri, 2013-09-27 at 15:38 +0100, Ian Campbell wrote:
>> @@ -535,6 +572,10 @@ int init_secondary_pagetables(int cpu)
>>      per_cpu(xen_pgtable, cpu) = first;
>>      per_cpu(xen_dommap, cpu) = domheap;
>>  
>> +    /* Set init_ttbr for this CPU coming up */
>> +    init_ttbr = (uintptr_t) THIS_CPU_PGTABLE + phys_offset;
>> +    flush_xen_dcache(init_ttbr);
>> +
>>      return 0;
>>  }
>>  #endif 
> 
> /me puts on his donkey ears.
> 
> We don't really want to run all 32-bit CPUs on CPU0's pagetables, do we
> now...

It's now boot on the arndale. With the 2 changes (this one and the
smp_cpus_init...):

Acked-by: Julien Grall <julien.grall@linaro.org>

> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 18fa979..99857ea 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -572,7 +572,7 @@ int init_secondary_pagetables(int cpu)
>      per_cpu(xen_dommap, cpu) = domheap;
>  
>      /* Set init_ttbr for this CPU coming up */
> -    init_ttbr = (uintptr_t) THIS_CPU_PGTABLE + phys_offset;
> +    init_ttbr = __pa(first);
>      flush_xen_dcache(init_ttbr);
>  
>      return 0;
> 
> Now, where did I put my brown paper bag.
> 
> Ian.
> 
> 


-- 
Julien Grall