From: Mark Tinguely <tinguely@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix memory leak in xlog_recover_add_to_trans
Date: Fri, 27 Sep 2013 12:34:13 -0500 [thread overview]
Message-ID: <5245C195.1080704@sgi.com> (raw)
In-Reply-To: <5245B86F.3030309@sandeen.net>
On 09/27/13 11:55, Eric Sandeen wrote:
> On 9/27/13 9:00 AM, tinguely@sgi.com wrote:
>> Free the memory in error path of xlog_recover_add_to_trans().
>> Normally this memory is freed in recovery pass2, but is leaked
>> in the error path.
>>
>> Signed-off-by: Mark Tinguely<tinguely@sgi.com>
>
> For this local leak & the fix,
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>
> Since this gets called in a loop from xlog_recover_process_data(),
> I'm wondering what happens to previously-allocated items, if we
> return an error and never get to pass2?
>
> (I could be off base, haven't really followed it through, but
> it seems like they might leak).
>
> Thanks,
> -Eric
yeah you are correct, it looks like it gets leaked.
I will add it to the list.
Thanks.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-27 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 14:00 [PATCH] xfs: fix memory leak in xlog_recover_add_to_trans tinguely
2013-09-27 16:55 ` Eric Sandeen
2013-09-27 17:34 ` Mark Tinguely [this message]
2013-09-27 17:35 ` Eric Sandeen
2013-09-30 22:53 ` Ben Myers
2013-10-01 13:20 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5245C195.1080704@sgi.com \
--to=tinguely@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.