From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Milo Kim <milo.kim@ti.com>
Cc: linux-leds@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Bo Shen <voice.shen@atmel.com>
Subject: Re: leds-pwm: issue in __led_pwm_set()
Date: Fri, 27 Sep 2013 20:34:47 +0200 [thread overview]
Message-ID: <5245CFC7.9070506@free-electrons.com> (raw)
In-Reply-To: <5245C161.6060704@ti.com>
On 27/09/2013 19:33, Milo Kim wrote:
> Sorry, I meant atmel_pwm_free(), not atmel_pwm_disable().
> - copy & paste disaster! :(
>
>> 2) Move atmel PWM register code to atmel_pwm_request() and _free()
>>
>> static int atmel_pwm_request(struct pwm_chip *chip, struct pwm_device
>> *pwm)
>> {
>> struct atmel_pwm_chip *atmel_pwm = to_atmel_pwm_chip(chip);
>>
>> atmel_pwm_writel(atmel_pwm, PWM_ENA, 1 << pwm->hwpwm);
>> return 0;
>> }
>>
>> static void atmel_pwm_disable(struct pwm_chip *chip, struct pwm_device
>> *pwm)
>
> static void atmel_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
>
>
Ok, I tested that and it seems to be working fine.
Thanks !
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-09-27 18:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 20:00 leds-pwm: issue in __led_pwm_set() Alexandre Belloni
2013-09-26 0:28 ` Milo Kim
2013-09-26 7:13 ` Alexandre Belloni
2013-09-26 7:34 ` Milo Kim
2013-09-26 7:48 ` Alexandre Belloni
2013-09-27 15:51 ` Milo Kim
2013-09-27 16:15 ` Alexandre Belloni
2013-09-27 17:23 ` Milo Kim
2013-09-27 17:33 ` Milo Kim
2013-09-27 18:34 ` Alexandre Belloni [this message]
2013-09-27 19:46 ` Alexandre Belloni
2013-09-28 13:29 ` Milo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5245CFC7.9070506@free-electrons.com \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-leds@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=nicolas.ferre@atmel.com \
--cc=thierry.reding@gmail.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.