All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	ian.campbell@citrix.com, linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH] xen/hvc-console: Make it work with HVM guests.
Date: Fri, 27 Sep 2013 22:49:37 +0100	[thread overview]
Message-ID: <5245FD71.3080408@linaro.org> (raw)
In-Reply-To: <1380317117-21719-1-git-send-email-konrad.wilk@oracle.com>

On 09/27/2013 10:25 PM, Konrad Rzeszutek Wilk wrote:

> @@ -641,7 +641,20 @@ struct console xenboot_console = {
>
>   void xen_raw_console_write(const char *str)
>   {
> -	dom0_write_console(0, str, strlen(str));
> +	ssize_t len = strlen(str);
> +	int rc = 0;
> +
> +	if (xen_domain()) {
> +		dom0_write_console(0, str, len);
> +		if (rc == -ENOSYS && xen_hvm_domain())
> +			goto outb_print;
> +
> +	} else if (xen_cpuid_base()) {
> +		int i;
> +outb_print:
> +		for (i = 0; i < len; i++)
> +			outb(str[i], 0xe9);
> +	}
>   }

xen_cpuid_base and outb(0xe9) is x86 specific and won't compile on ARM.
You need to add ifdef around.

-- 
Julien Grall

  parent reply	other threads:[~2013-09-27 21:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27 21:25 [PATCH] xen/hvc-console: Make it work with HVM guests Konrad Rzeszutek Wilk
2013-09-27 21:49 ` Julien Grall
2013-09-27 21:49 ` Julien Grall [this message]
2013-09-30 14:45   ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-10-06 20:52     ` Julien Grall
2013-10-23 16:15       ` Konrad Rzeszutek Wilk
2013-10-23 22:08         ` Julien Grall
2013-10-23 22:08         ` [Xen-devel] " Julien Grall
2013-10-24 14:49           ` Konrad Rzeszutek Wilk
2013-10-24 14:49           ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-10-24 16:30             ` Julien Grall
2013-10-24 16:30             ` [Xen-devel] " Julien Grall
2013-10-24 16:43               ` Ian Campbell
2013-10-24 16:43               ` [Xen-devel] " Ian Campbell
2013-10-25 19:38                 ` Konrad Rzeszutek Wilk
2013-10-26  8:27                   ` Ian Campbell
2013-10-26  8:27                   ` [Xen-devel] " Ian Campbell
2013-10-28 15:48                     ` Konrad Rzeszutek Wilk
2013-10-28 15:48                     ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-10-25 19:38                 ` Konrad Rzeszutek Wilk
2013-10-23 16:15       ` Konrad Rzeszutek Wilk
2013-10-06 20:52     ` Julien Grall
2013-09-30 14:45   ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5245FD71.3080408@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.