Re: [PATCH] ACPI/thermal : Remove zone disabled warning

[Eduardo Valentin <eduardo.valentin@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

On 25-09-2013 12:29, Srinivas Pandruvada wrote:
> Once thermal zone is disabled to move thermal control to user space,
> too many warnings printed in logs. Remove pr_warn from this path,
> instead warn when user mode issues request to disable thermal zone.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

Although this is actually really under Rui's, I believe this patch makes
sense to me. So, you can add my acked.

Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>

> ---
>  drivers/acpi/thermal.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> index 6a03293..92bebb9 100644
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -515,10 +515,9 @@ static void acpi_thermal_check(void *data)
>  {
>  	struct acpi_thermal *tz = data;
>  
> -	if (!tz->tz_enabled) {
> -		pr_warn("thermal zone is disabled \n");
> +	if (!tz->tz_enabled)
>  		return;
> -	}
> +
>  	thermal_zone_device_update(tz->thermal_zone);
>  }
>  
> @@ -570,9 +569,10 @@ static int thermal_set_mode(struct thermal_zone_device *thermal,
>  	 */
>  	if (mode == THERMAL_DEVICE_ENABLED)
>  		enable = 1;
> -	else if (mode == THERMAL_DEVICE_DISABLED)
> +	else if (mode == THERMAL_DEVICE_DISABLED) {
>  		enable = 0;
> -	else
> +		pr_warn("thermal zone will be disabled\n");
> +	} else
>  		return -EINVAL;
>  
>  	if (enable != tz->tz_enabled) {
> 


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]