All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/1] iio: amplifiers: ad8366: Remove regulator_put
Date: Sat, 28 Sep 2013 11:50:19 +0100	[thread overview]
Message-ID: <5246B46B.9040106@kernel.org> (raw)
In-Reply-To: <1380023350-25116-1-git-send-email-sachin.kamat@linaro.org>

On 09/24/13 12:49, Sachin Kamat wrote:
> Since devm_regulator_get is used, regulator_put should not be
> used. Remove it.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied to the fixes-togreg branch of iio.git

Thanks
> ---
>  drivers/iio/amplifiers/ad8366.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/amplifiers/ad8366.c b/drivers/iio/amplifiers/ad8366.c
> index d0a79a4..ba6f6a9 100644
> --- a/drivers/iio/amplifiers/ad8366.c
> +++ b/drivers/iio/amplifiers/ad8366.c
> @@ -185,10 +185,8 @@ static int ad8366_remove(struct spi_device *spi)
>  
>  	iio_device_unregister(indio_dev);
>  
> -	if (!IS_ERR(reg)) {
> +	if (!IS_ERR(reg))
>  		regulator_disable(reg);
> -		regulator_put(reg);
> -	}
>  
>  	return 0;
>  }
> 

      reply	other threads:[~2013-09-28  9:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-24 11:49 [PATCH 1/1] iio: amplifiers: ad8366: Remove regulator_put Sachin Kamat
2013-09-28 10:50 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5246B46B.9040106@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.