From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] ethdev: allow all ports event registration
Date: Sat, 30 Dec 2017 21:51:06 +0100 [thread overview]
Message-ID: <5248035.SzZHBmRRCd@xps> (raw)
In-Reply-To: <AM6PR0502MB379715DDE526109D7C648AD0D21A0@AM6PR0502MB3797.eurprd05.prod.outlook.com>
30/12/2017 20:04, Matan Azrad:
> From: Thomas Monjalon, December 29, 2017
> > 04/12/2017 16:43, Matan Azrad:
> > > @@ -2827,37 +2837,59 @@
> > > + uint32_t next_port;
> > > + uint32_t last_port;
> >
> > A port id should be uint16_t.
> >
> Yes, I know but please note that we use next_port variable in the while statement and it can be rolled in case the max value of port id is the max value of uint16_t type.
> This is the reason I defined it as uint32_t type.
OK, so I suggest 2 possible fixes:
- either keep uint32_t with a comment in the code.
- or use a for loop
What do you prefer?
next prev parent reply other threads:[~2017-12-30 20:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 7:49 [PATCH] ethdev: allow all ports event registration Matan Azrad
2017-12-04 15:43 ` [PATCH v2] " Matan Azrad
2017-12-29 11:45 ` Thomas Monjalon
2017-12-30 19:04 ` Matan Azrad
2017-12-30 20:51 ` Thomas Monjalon [this message]
2017-12-30 21:14 ` Matan Azrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5248035.SzZHBmRRCd@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.