Re: adding can4linux to drivers/char

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1986 bytes --]

On 09/29/2013 06:28 PM, Heinz-Jürgen Oertel wrote:
> Am Samstag, 21. September 2013, 21:55:45 schrieb Wolfgang Grandegger:
>> I think you need *strong* arguments to get it accepted. 
> 
> I have some good arguments for this kind of driver
> - it is much more simple in design than others,
>   simplicity is one of the Linux design goals

What is in your opinion too complicated about linux CAN? Is it a lack of
Documentation or examples?

> - It has a simple user API

For a simple program you need socket(), bind(), read(), write().

> - It does not need any other infrastructure than the kernel API

This is another way of telling, we've reinvented the rest on our own.

> - It is mature

The ultimate question is: What problem does it solve?

> I agree, it would be nice to share the low level CAN controller related 
> experiences of the developers. That is may be something we can share if we 
> could agree of a set of CAN controller header files with shared register 
> #defines. And a set of very basic functions like initialize and activate CAN, 
> set acceptance filters, transmit and receive, read out error register or 
> whatever.

Like the driver and the socket infrastructure?

> But to stay simple, I don't like the idea to have another additional layer 
> around SocketCAN as layer below the can4linux API.

Does this mean you want to duplicate the drivers?

> Linux offers real diversity on the desktop, why not with drivers? Linux also 
> has different sound devices and architectures.  Why not offering two different 
> CAN driver concepts to the application programmer,
> let she decide what to use.

Sorry, but I can only NAK this idea.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]