Re: [Qemu-trivial] [PATCH] block: Remove unused assignment (fixes warning from clang)

[Michael Tokarev <mjt@tls.msk.ru>]

28.09.2013 13:55, Stefan Weil wrote:
> blockdev.c:1929:13: warning: Value stored to 'ret' is never read
>              ret = 0;
>              ^     ~

Applied to the trivial patches queue.

> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>   blockdev.c |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index 8aa66a9..8c83f6f 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1926,7 +1926,6 @@ void qmp_drive_mirror(const char *device, const char *target,
>       } else {
>           switch (mode) {
>           case NEW_IMAGE_MODE_EXISTING:
> -            ret = 0;
>               break;

While this one is obviously unused assignment,
there's on more usage of `ret' variable in this
function, -- it is to store the return value
from bdrv_open():

     ret = bdrv_open(target_bs, target, NULL, flags | BDRV_O_NO_BACKING, drv,
                     &local_err);
     if (ret < 0) {...

What's the rule about converting that into if() ?

Thanks,

/mjt