All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] glibc: Pass correct -mabi for MIPS
Date: Mon, 30 Sep 2013 09:33:47 +0100	[thread overview]
Message-ID: <5249376B.5020407@imgtec.com> (raw)
In-Reply-To: <1380121257-10449-1-git-send-email-markos.chandras@imgtec.com>

On 09/25/13 16:00, Markos Chandras wrote:
> According to glibc-2.18/ports/sysdeps/mips/preconfigure,
> if no -mabi was passed to CFLAGS, then it defaults to -mabi=n32.
> This breaks o32 and n64 builds for MIPS64. Therefore, it is
> necessary to append -mabi to CFLAGS.
>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
>   package/glibc/glibc.mk | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/package/glibc/glibc.mk b/package/glibc/glibc.mk
> index 4dd2e63..68c4636 100644
> --- a/package/glibc/glibc.mk
> +++ b/package/glibc/glibc.mk
> @@ -43,6 +43,16 @@ ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
>   GLIBC_EXTRA_CFLAGS += -marm
>   endif
>
> +# MIPS64 defaults to n32 so pass the correct -mabi if
> +# we are using a different ABI. OABI32 is also used
> +# in MIPS so we pass -mabi=32 in this case as well
> +# even though it's not strictly necessary.
> +ifeq ($(BR2_MIPS_NABI64),y)
> +GLIBC_EXTRA_CFLAGS += -mabi=64
> +else ifeq ($(BR2_MIPS_OABI32),y)
> +GLIBC_EXTRA_CFLAGS += -mabi=32
> +endif
> +
>   # Even though we use the autotools-package infrastructure, we have to
>   # override the default configure commands for several reasons:
>   #
>
Ping? :)

  reply	other threads:[~2013-09-30  8:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-25 15:00 [Buildroot] [PATCH] glibc: Pass correct -mabi for MIPS Markos Chandras
2013-09-30  8:33 ` Markos Chandras [this message]
2013-10-01 21:33 ` Thomas Petazzoni
2013-10-01 21:59 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5249376B.5020407@imgtec.com \
    --to=markos.chandras@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.