All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: peter.crosthwaite@xilinx.com, stefanha@redhat.com,
	Marcel Apfelbaum <marcel.a@redhat.com>,
	sw@weilnetz.de, jasowang@redhat.com,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	dkoch@verizon.com, alex.williamson@redhat.com,
	paul@codesourcery.com, anthony@codemonkey.ws, afaerber@suse.de,
	kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin
Date: Mon, 30 Sep 2013 11:02:06 +0200	[thread overview]
Message-ID: <52493E0E.1060308@redhat.com> (raw)
In-Reply-To: <20130930085815.GA20291@redhat.com>

Il 30/09/2013 10:58, Michael S. Tsirkin ha scritto:
>>> > > As a next step, can we make pci_set_irq non-inline and make
>>> > > it call pci_irq_handler directly, and get rid of the irq field?
>> > What irq field? 
>     /* IRQ objects for the INTA-INTD pins.  */
>     qemu_irq *irq;
> 

That's still used by devices that use common code for PCI and sysbus
versions (e.g. USB OHCI and EHCI).

Paolo

  reply	other threads:[~2013-09-30  9:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-29 14:40 [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin Marcel Apfelbaum
2013-09-29 14:40 ` [Qemu-devel] [PATCH 1/3] hw/pci: " Marcel Apfelbaum
2013-09-29 14:40 ` [Qemu-devel] [PATCH 2/3] hw/pci-bridge: set PCI_INTERRUPT_PIN register before shpc init Marcel Apfelbaum
2013-09-29 14:40 ` [Qemu-devel] [PATCH 3/3] hw: assert/deassert interrupts using pci_set_irq wrapper Marcel Apfelbaum
2013-09-29 15:06 ` [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin Michael S. Tsirkin
2013-09-29 15:24   ` Marcel Apfelbaum
2013-09-29 15:31     ` Michael S. Tsirkin
2013-09-30  8:14   ` Marcel Apfelbaum
2013-09-30  8:58     ` Michael S. Tsirkin
2013-09-30  9:02       ` Paolo Bonzini [this message]
2013-09-30  9:14         ` Michael S. Tsirkin
2013-09-30  9:43           ` Marcel Apfelbaum
2013-09-30 10:10             ` Michael S. Tsirkin
2013-09-30 10:39               ` Marcel Apfelbaum
2013-09-30 10:58                 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52493E0E.1060308@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=dkoch@verizon.com \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcel.a@redhat.com \
    --cc=mst@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.