All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sricharan R <r.sricharan@ti.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Tony Lindgren <tony@atomide.com>,
	OMAP SUPPORT <linux-omap@vger.kernel.org>,
	Rajendra Nayak <rnayak@ti.com>
Subject: Re: [PATCH] ARM: OMAP2+: timer: build with DRA7xx enable but without OMAP5
Date: Mon, 30 Sep 2013 14:50:16 +0530	[thread overview]
Message-ID: <52494250.6060809@ti.com> (raw)
In-Reply-To: <1380532531-21021-1-git-send-email-bigeasy@linutronix.de>

On Monday 30 September 2013 02:45 PM, Sebastian Andrzej Siewior wrote:
> with DRA7xx and without OMAP5 selected we get
> |arch/arm/mach-omap2/built-in.o:(.arch.info.init+0x40): undefined reference to `omap5_realtime_timer_init'
> |make[1]: *** [vmlinux] Error 1
>
> since ARM: DRA7: board-generic: Add basic DT support ("439bf39e").
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: R Sricharan <r.sricharan@ti.com>
> Cc: Rajendra Nayak <rnayak@ti.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  arch/arm/mach-omap2/timer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> index fa74a06..4fd1816 100644
> --- a/arch/arm/mach-omap2/timer.c
> +++ b/arch/arm/mach-omap2/timer.c
> @@ -628,7 +628,7 @@ void __init omap4_local_timer_init(void)
>  #endif /* CONFIG_HAVE_ARM_TWD */
>  #endif /* CONFIG_ARCH_OMAP4 */
>  
> -#ifdef CONFIG_SOC_OMAP5
> +#if defined(CONFIG_SOC_OMAP5) || defined(CONFIG_SOC_DRA7XX)
>  void __init omap5_realtime_timer_init(void)
>  {
>  	omap4_sync32k_timer_init();
Yes, this was missing. Thanks for the fix.

Regards,
 Sricharan


      reply	other threads:[~2013-09-30  9:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30  9:15 [PATCH] ARM: OMAP2+: timer: build with DRA7xx enable but without OMAP5 Sebastian Andrzej Siewior
2013-09-30  9:20 ` Sricharan R [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52494250.6060809@ti.com \
    --to=r.sricharan@ti.com \
    --cc=bigeasy@linutronix.de \
    --cc=linux-omap@vger.kernel.org \
    --cc=rnayak@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.