From mboxrd@z Thu Jan 1 00:00:00 1970 From: Afzal Mohammed Subject: Re: [PATCH v4 06/11] ARM: OMAP2+: PM: AM43x powerdomain data Date: Mon, 30 Sep 2013 17:44:12 +0530 Message-ID: <52496B14.9090902@ti.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:42461 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754547Ab3I3MOm (ORCPT ); Mon, 30 Sep 2013 08:14:42 -0400 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley , Ambresh K Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Benoit Cousson , Tony Lindgren , Rajendra Nayak Hi Paul, On Monday 30 September 2013 03:57 PM, Paul Walmsley wrote: > On Thu, 26 Sep 2013, Afzal Mohammed wrote: >> From: Ambresh K >> >> Add the data file to describe all power domains in AM43x SoC. >> OMAP4 powerdomain operations is being reused here. >> >> Signed-off-by: Ambresh K >> Signed-off-by: Afzal Mohammed > > ... > >> --- /dev/null >> +++ b/arch/arm/mach-omap2/powerdomains43xx_data.c >> @@ -0,0 +1,142 @@ > > ... > >> +static struct powerdomain per_43xx_pwrdm = { >> + .name = "per_pwrdm", >> + .voltdm = { .name = "core" }, >> + .prcm_offs = AM43XX_PRM_PER_INST, >> + .prcm_partition = AM43XX_PRM_PARTITION, >> + .pwrsts = PWRSTS_OFF_RET_ON, >> + .pwrsts_logic_ret = PWRSTS_OFF_RET, >> + .banks = 4, >> + .pwrsts_mem_ret = { >> + [0] = PWRSTS_OFF_RET, /* icss_mem */ >> + [1] = PWRSTS_OFF_RET, /* per_mem */ >> + [2] = PWRSTS_OFF_RET, /* ram1_mem */ >> + [3] = PWRSTS_OFF_RET, /* ram2_mem */ >> + }, >> + .pwrsts_mem_on = { >> + [0] = PWRSTS_OFF_RET, /* icss_mem */ >> + [1] = PWRSTS_ON, /* per_mem */ >> + [2] = PWRSTS_OFF_RET, /* ram1_mem */ >> + [3] = PWRSTS_OFF_RET, /* ram2_mem */ >> + }, >> + .flags = PWRDM_HAS_LOWPOWERSTATECHANGE, >> +}; > > The pwrsts_mem_on flags don't make any sense here for banks 0, 2, and 3. > They claim that those banks can never be turned on. Could you please > doublecheck these? Checked it, they should be PWRSTS_ON, I will fix it. Regards Afzal From mboxrd@z Thu Jan 1 00:00:00 1970 From: afzal@ti.com (Afzal Mohammed) Date: Mon, 30 Sep 2013 17:44:12 +0530 Subject: [PATCH v4 06/11] ARM: OMAP2+: PM: AM43x powerdomain data In-Reply-To: References: Message-ID: <52496B14.9090902@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Paul, On Monday 30 September 2013 03:57 PM, Paul Walmsley wrote: > On Thu, 26 Sep 2013, Afzal Mohammed wrote: >> From: Ambresh K >> >> Add the data file to describe all power domains in AM43x SoC. >> OMAP4 powerdomain operations is being reused here. >> >> Signed-off-by: Ambresh K >> Signed-off-by: Afzal Mohammed > > ... > >> --- /dev/null >> +++ b/arch/arm/mach-omap2/powerdomains43xx_data.c >> @@ -0,0 +1,142 @@ > > ... > >> +static struct powerdomain per_43xx_pwrdm = { >> + .name = "per_pwrdm", >> + .voltdm = { .name = "core" }, >> + .prcm_offs = AM43XX_PRM_PER_INST, >> + .prcm_partition = AM43XX_PRM_PARTITION, >> + .pwrsts = PWRSTS_OFF_RET_ON, >> + .pwrsts_logic_ret = PWRSTS_OFF_RET, >> + .banks = 4, >> + .pwrsts_mem_ret = { >> + [0] = PWRSTS_OFF_RET, /* icss_mem */ >> + [1] = PWRSTS_OFF_RET, /* per_mem */ >> + [2] = PWRSTS_OFF_RET, /* ram1_mem */ >> + [3] = PWRSTS_OFF_RET, /* ram2_mem */ >> + }, >> + .pwrsts_mem_on = { >> + [0] = PWRSTS_OFF_RET, /* icss_mem */ >> + [1] = PWRSTS_ON, /* per_mem */ >> + [2] = PWRSTS_OFF_RET, /* ram1_mem */ >> + [3] = PWRSTS_OFF_RET, /* ram2_mem */ >> + }, >> + .flags = PWRDM_HAS_LOWPOWERSTATECHANGE, >> +}; > > The pwrsts_mem_on flags don't make any sense here for banks 0, 2, and 3. > They claim that those banks can never be turned on. Could you please > doublecheck these? Checked it, they should be PWRSTS_ON, I will fix it. Regards Afzal