From: David Vrabel <dvrabel@cantab.net>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
keir@xen.org, tim@xen.org, Ian.Campbell@citrix.com,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH v6 4/5] xen: introduce XENMEM_exchange_and_pin and XENMEM_unpin
Date: Mon, 30 Sep 2013 13:42:56 +0100 [thread overview]
Message-ID: <524971D0.5070804@cantab.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1309301314530.5498@kaball.uk.xensource.com>
On 30/09/13 13:30, Stefano Stabellini wrote:
> On Mon, 30 Sep 2013, Jan Beulich wrote:
>>>>> On 27.09.13 at 18:15, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
>>> Changes in v6:
>>> - do not change error paths;
>>> - crash the guest on pinning failure;
>>
>> Isn't that a little harsh?
>
> I agree that this is harsh, but it's quite difficult to undo the
> page exchange that was previously done up to the point of failure. And a
> pinning error can only be caused by a misbehaviour of the guest.
> Overall this is a simple solution to a difficult problem.
Do you need to undo the exchange if the pinning failed? Or could return
an error status of "exchanged but not pinned" and have the guest do the
right thing?
David
next prev parent reply other threads:[~2013-09-30 12:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 16:15 [PATCH v6 0/5] introduce XENMEM_exchange_and_pin, XENMEM_unpin and XENMEM_pin Stefano Stabellini
2013-09-27 16:15 ` [PATCH v6 1/5] xen: move steal_page and donate_page to common code Stefano Stabellini
2013-09-30 7:26 ` Jan Beulich
2013-09-27 16:15 ` [PATCH v6 2/5] xen/arm: introduce a generic p2m walker and use it in p2m_lookup Stefano Stabellini
2013-09-27 16:15 ` [PATCH v6 3/5] xen: implement guest_physmap_pin_range and guest_physmap_unpin_range Stefano Stabellini
2013-09-27 16:15 ` [PATCH v6 4/5] xen: introduce XENMEM_exchange_and_pin and XENMEM_unpin Stefano Stabellini
2013-09-30 7:36 ` Jan Beulich
2013-09-30 12:30 ` Stefano Stabellini
2013-09-30 12:42 ` David Vrabel [this message]
2013-09-27 16:16 ` [PATCH v6 5/5] xen: introduce XENMEM_pin Stefano Stabellini
2013-09-30 7:41 ` Jan Beulich
2013-09-30 12:56 ` Stefano Stabellini
2013-09-30 13:02 ` Ian Campbell
2013-09-30 13:03 ` Tim Deegan
2013-09-30 13:53 ` Stefano Stabellini
2013-09-30 13:14 ` Jan Beulich
2013-09-30 14:31 ` Stefano Stabellini
2013-09-30 15:27 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524971D0.5070804@cantab.net \
--to=dvrabel@cantab.net \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.