From: Frederic Danis <frederic.danis@linux.intel.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 2/3] android: Add skeleton of BlueZ Android daemon
Date: Mon, 30 Sep 2013 16:36:55 +0200 [thread overview]
Message-ID: <52498C87.7000007@linux.intel.com> (raw)
In-Reply-To: <2A24E0BD-2EFF-4811-833E-A850B1469054@holtmann.org>
Hello Marcel,
On 27/09/2013 04:05, Marcel Holtmann wrote:
>> Define local mapping to glib path, otherwise this has to be inside central
>> >place in the build repository.
>> >
>> >Retrieve Bluetooth version from configure.ac.
>> >---
>> >.gitignore | 2 +
>> >Makefile.android | 5 +++
> I rather keep the changes to a global Makefile separate from the android/ stuff.
>
>> >android/Android.mk | 24 ++++++++++++
>> >android/main.c | 110 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>> >4 files changed, 141 insertions(+)
>> >create mode 100644 android/main.c
> It is perfectly fine to split this into two patches. Add the *.c file(s) first and in a second patch add the build changes.
>
Ok, so I will send .gitignore, Makefile.android and Android.mk in a
second patch.
Regards
Fred
--
Frederic Danis Open Source Technology Center
frederic.danis@intel.com Intel Corporation
next prev parent reply other threads:[~2013-09-30 14:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 12:13 [PATCH v2 1/3] build: Add skeleton for BlueZ Android Frederic Danis
2013-09-24 12:13 ` [PATCH v2 2/3] android: Add skeleton of BlueZ Android daemon Frederic Danis
2013-09-27 2:05 ` Marcel Holtmann
2013-09-30 14:36 ` Frederic Danis [this message]
2013-09-24 12:13 ` [PATCH v2 3/3] android: Android version of log.c Frederic Danis
2013-09-27 2:01 ` Marcel Holtmann
2013-09-30 14:37 ` Frederic Danis
2013-09-30 19:26 ` Andrei Emeltchenko
2013-09-24 12:57 ` [PATCH v2 1/3] build: Add skeleton for BlueZ Android Anderson Lizardo
2013-09-27 2:08 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52498C87.7000007@linux.intel.com \
--to=frederic.danis@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.