All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hector Palacios <hector.palacios@digi.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	Huang Shijie <b32955@freescale.com>,
	"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
	"fabio.estevam@freescale.com" <fabio.estevam@freescale.com>,
	Marek Vasut <marex@denx.de>
Subject: Re: mxs auart timeout waiting for transmission with hw flow control
Date: Mon, 30 Sep 2013 18:41:25 +0200	[thread overview]
Message-ID: <5249A9B5.2080903@digi.com> (raw)
In-Reply-To: <20130930162044.GG2548@pengutronix.de>

Hi Uwe,

On 09/30/2013 06:20 PM, Uwe Kleine-König wrote:
> Hi Hector,
>
> On Mon, Sep 30, 2013 at 06:07:19PM +0200, Hector Palacios wrote:
>> I saw your patch at
>> http://www.spinics.net/lists/stable/msg12952.html and I believe I'm
>> having a similar issue when not using the port as console.
>>
>> With hardware flow control enabled transmission fails at low
>> baudrates (9600,38400). Apparently the transmitter closes the port
> Which kernel are you using? I think there were some other fixes
> concering flow control some time ago.

v3.10. The driver is pretty close to current status.

>> before the data has been really shifted out (or even transferred by
>> the DMA). While the console functions check the status of
>> AUART_STAT_BUSY, the standard functions don't, and the AUART is busy
>> when shutdown is called at low baudrates.
>>
>> I also see the function uart_wait_until_sent() of serial_core.c
>> getting out with timeout expired. At 9600 baud, this function waits
>> 2 or 4 jiffies. Increasing (a lot) the timeout of this function
>> solves the problem. I monitored the time it takes for TX to be empty
>> and it resulted in sometimes around 200 jiffies (@9600).
> Again with flow control and another imx28 on the opposite side? Does it
> work without flow control? Is CTS busy for some time? In that case a
> simple timeout isn't appropriate. Using console and flow control on the
> same port might be hairy, not sure though.

Yes, two imx28 devices with hw flow control enabled. Without flow control it works.
CTS is not busy. At these low baudrates the CPU is fast enough to process the received 
data in time.
I'm not using the AUART as console but as a standard port.

>> The issue can be reproduced using two iMX28 devices (transmitting
>> between two ports on the same platform usually works fine),
>> configuring a low baudrate (9600) and hardware flow enabled, and
>> sending a file of 40K, for example. The last ~200 bytes or so are
>> typically not sent over the line.
> I currently don't have the time and machines to test, but maybe the
> freescale guys (added Fabio to Cc, too) might want to test it.
>
> Best regards from Freiburg

I wish I could drop by Freiburg one of these days! Love the city (and the beer).

Best regards,
--
Hector Palacios
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-09-30 16:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30 16:07 mxs auart timeout waiting for transmission with hw flow control Hector Palacios
2013-09-30 16:20 ` Uwe Kleine-König
2013-09-30 16:41   ` Hector Palacios [this message]
2013-10-01 15:37     ` Hector Palacios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5249A9B5.2080903@digi.com \
    --to=hector.palacios@digi.com \
    --cc=b32955@freescale.com \
    --cc=fabio.estevam@freescale.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=shawn.guo@linaro.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.