Re: [Qemu-devel] [PATCH v6 0/6] Provide additional info through qemu-img info

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2273 bytes --]

On 10/01/2013 06:31 AM, Max Reitz wrote:
> qemu-img info provides only pretty general information about an image.
> For any image format, there might be specific options which cannot be
> represented in a universal way; for instance, qcow2 provides the
> compatibility and lazy_refcount options whose values are certainly
> interesting but currently cannot be output by qemu-img info.
> 
> Therefore, this series adds a new ImageInfoSpecific union type to
> ImageInfo which may be used by block drivers as a template for new types
> dedicated to the specific information they can provide, as well as a
> function bdrv_get_specific_info for retrieving this information. It also
> adds support to qemu-img info and qemu-io -c info to print the content
> of these specific structures.
> 
> v6:
>  - implemented Eric's remarks:
>    - corrected description of ImageInfo in qapi-schema.json (patch 1)
>    - added root indentation in bdrv_image_info_specific_dump (patch 3);
>      Although this is a very minor change, I dropped Eric's Reviewed-by
>      because of it, since I'm not sure myself whether the place I've
>      added the indentation is actually the right one (maybe the caller
>      of bdrv_image_info_specific_dump should control the indentation
>      instead of hardcoding it into the function).
>      Furthermore, this (his) suggestion was not part of his review for
>      this patch, but for patch 6.

I think what you did was fine (if we ever have a reason to reuse
bdrv_image_info_specific_dump in a new location with different
indentation, we could rework it to add an indentation parameter at that
time).  And I like how the output now looks in the updated 6/6 patch.

>    - changed patch 5 from using some non-portable expressions to fully
>      bash-specific ones
>    - use $() instead of `` and $PWD instead of `pwd` in patch 6 and
>      indent format specific information in reference output (according
>      to change in patch 3)
>  - rebased on Kevin's block branch (changed some line numbers and the
>    diff environment in patch 5)

Series: Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]