From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR0vr-0005Lk-N4 for qemu-devel@nongnu.org; Tue, 01 Oct 2013 10:28:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VR0vl-0005mu-OR for qemu-devel@nongnu.org; Tue, 01 Oct 2013 10:28:11 -0400 Received: from mel.act-europe.fr ([194.98.77.210]:41034 helo=smtp.eu.adacore.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR0vl-0005mc-Ix for qemu-devel@nongnu.org; Tue, 01 Oct 2013 10:28:05 -0400 Message-ID: <524ADBF3.9090105@adacore.com> Date: Tue, 01 Oct 2013 16:28:03 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1380556655-22282-1-git-send-email-chouteau@adacore.com> <1380556655-22282-4-git-send-email-chouteau@adacore.com> <524A2CA4.40000@twiddle.net> In-Reply-To: <524A2CA4.40000@twiddle.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, afaerber@suse.de, lcapitulino@redhat.com On 10/01/2013 04:00 AM, Richard Henderson wrote: > On 09/30/2013 08:57 AM, Fabien Chouteau wrote: >> +extern const MonitorDef arch_monitor_defs[]; > > This is supplied by target-foo/monitor.c, right? > Why in the world is it declared in generic code? > Yes, why? > Especially if it's only ever accessed via the > cpu->monitor_defs member? > To begin with, I though I'd put in in each target-*/cpu.c, then having it at only one place seemed more clean. I'm open to any suggestion. -- Fabien Chouteau