From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR2Gi-0001Cu-MU for qemu-devel@nongnu.org; Tue, 01 Oct 2013 11:53:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VR2Gd-0003Xt-J8 for qemu-devel@nongnu.org; Tue, 01 Oct 2013 11:53:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR2Gd-0003Xc-9E for qemu-devel@nongnu.org; Tue, 01 Oct 2013 11:53:43 -0400 Message-ID: <524AF001.2000307@redhat.com> Date: Tue, 01 Oct 2013 09:53:37 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380633619-12213-1-git-send-email-kwolf@redhat.com> <1380633619-12213-7-git-send-email-kwolf@redhat.com> In-Reply-To: <1380633619-12213-7-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Xfw92t1JVTLQWCgDlhb22XECPGJA35lkF" Subject: Re: [Qemu-devel] [PATCH v2 06/17] blockdev: Pass QDict to blockdev_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: benoit.canet@irqsave.net, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, xiawenc@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Xfw92t1JVTLQWCgDlhb22XECPGJA35lkF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/01/2013 07:20 AM, Kevin Wolf wrote: > Working on a QDict instead of a QemuOpts that accepts anything is more > in line with bdrv_open(). A QDict is what qmp_blockdev_add() already ha= s > anyway, so this saves additional conversions. And last, but not least, > it allows later patches to easily extract legacy options into a > separate, typed QemuOpts for drive_init() (the untyped QemuOpts that > drive_init already has doesn't allow access to numbers, only strings, > and is therefore useless without conversion). >=20 > Signed-off-by: Kevin Wolf > Reviewed-by: Benoit Canet > --- > blockdev.c | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Xfw92t1JVTLQWCgDlhb22XECPGJA35lkF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSSvABAAoJEKeha0olJ0NqSB0H/2RJC5o1akh8mEofIuBMs/dZ iid35YBHSzyCSSyAOBWayXqiUuFAmP5s4S+UF3RJrqU36fEVaHofW/fYCBVXIEbC JDz5OzqAj8XMnyZHfU5fMu3BrXFScgzfJoswpuiAWqr4gY07RzohGiIqtP7gzaaY K7fT2JgIhGH9Qz+RSlwoPeG2cXT1uj6ucNJmHKDcL6PHIuubtRXus2BXvQRYyRq/ 3sFoosbu9rvSfNPN6ZdeN3CcB13pY+eksqq+Q99kAlbaa8jvsVSyzC5kKQdf69z4 oZzS7oZC8mgG/OvVu84NCtOMI/jJsig1SCHnOYYWUa3FWkkxPvbhKh6P7lnwefo= =OcE8 -----END PGP SIGNATURE----- --Xfw92t1JVTLQWCgDlhb22XECPGJA35lkF--