From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR2JO-000547-5U for qemu-devel@nongnu.org; Tue, 01 Oct 2013 11:56:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VR2JF-0004sD-Ou for qemu-devel@nongnu.org; Tue, 01 Oct 2013 11:56:34 -0400 Received: from mail-yh0-x22b.google.com ([2607:f8b0:4002:c01::22b]:58522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VR2JF-0004rX-LM for qemu-devel@nongnu.org; Tue, 01 Oct 2013 11:56:25 -0400 Received: by mail-yh0-f43.google.com with SMTP id b6so2551933yha.30 for ; Tue, 01 Oct 2013 08:56:25 -0700 (PDT) Sender: Richard Henderson Message-ID: <524AF0A4.5030206@twiddle.net> Date: Tue, 01 Oct 2013 08:56:20 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1379945085-29086-1-git-send-email-rth@twiddle.net> <1379945085-29086-2-git-send-email-rth@twiddle.net> <5249BD03.60608@suse.de> <5249CDDD.3080100@twiddle.net> <524AEED6.4050908@suse.de> <524AEFAB.8060701@twiddle.net> <524AF03D.5090308@suse.de> In-Reply-To: <524AF03D.5090308@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= On 10/01/2013 08:54 AM, Alexander Graf wrote: > Just make sure you actually check for feature bits on every instruction (which > I think you do, but the current code is way too magical to me to really > understand it anymore) so that we can always implement a z900 cpu type later on. Yes, the code to check is in "translate_one". Which, as you might imagine, translates one instruction. ;-) r~