From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 2] make clean: improve when no .config present
Date: Tue, 01 Oct 2013 19:20:55 +0200 [thread overview]
Message-ID: <524B0477.1030604@mind.be> (raw)
In-Reply-To: <20130930140438.713b4879@skate>
On 09/30/13 14:04, Thomas Petazzoni wrote:
> Dear Thomas De Schampheleire,
>
> On Mon, 30 Sep 2013 13:09:26 +0200, Thomas De Schampheleire wrote:
>> The 'make clean' recipe is using variables that are not defined without .config
>> file, causing only a partial cleanup when the .config file is accidentally
>> deleted.
>>
>> This patch moves those variables that do not depend on values from .config
>> outside the BR2_HAVE_DOT_CONFIG check, so that 'make clean' is much more similar
>> with and without .config.
>
> Yeah, this has bothered me for a while, so I agree with that.
>
>> The HOST_DIR (and the derived STAGING_DIR) are determined from BR2_HOST_DIR in
>> .config, so the host directory can still not be cleaned correctly without making
>> assumptions, if no .config is present.
>>
>> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
>>
>> ---
>> Note: we could improve the HOST_DIR cleanup by removing 'output/host'
>> unconditionally, but it's an assumption. Let me know your thoughts on this, it
>> could be fixed in another patch.
>
> Hum, yeah, indeed. This means that the contents of output/host are not
> removed, which is quite annoying. I don't immediately see a solution to
> this problem, though.
I would be OK with defining HOST_DIR as $(BASE_DIR)/host before .config
is included. If .config exists, it will be overridden afterwards.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-10-01 17:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 11:09 [Buildroot] [PATCH 0 of 2] 'make clean' improvements Thomas De Schampheleire
2013-09-30 11:09 ` [Buildroot] [PATCH 1 of 2] make clean: improve when no .config present Thomas De Schampheleire
2013-09-30 12:04 ` Thomas Petazzoni
2013-10-01 17:20 ` Arnout Vandecappelle [this message]
2013-10-01 19:55 ` Peter Korsgaard
2013-09-30 11:09 ` [Buildroot] [PATCH 2 of 2] make clean: remove redundant removal of STAGING_DIR Thomas De Schampheleire
2013-10-01 17:21 ` Arnout Vandecappelle
2013-10-01 19:59 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524B0477.1030604@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.