From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] gst-fsl-plugins: Bump version and change URL to match other i.MX components
Date: Tue, 01 Oct 2013 22:48:26 +0200 [thread overview]
Message-ID: <524B351A.6000200@mind.be> (raw)
In-Reply-To: <1380650790-18097-3-git-send-email-eric.nelson@boundarydevices.com>
On 10/01/13 20:06, Eric Nelson wrote:
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk b/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
> index ccdb521..00c6acb 100644
> --- a/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
> +++ b/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
> @@ -4,9 +4,11 @@
> #
> ################################################################################
>
> -GST_FSL_PLUGINS_VERSION = 3.0.1
> -# No official download site from freescale, just this mirror
> -GST_FSL_PLUGINS_SITE = http://download.ossystems.com.br/bsp/freescale/source
> +include package/freescale-imx/freescale-imx.inc
This is make, not C. You should never include the same file twice
unless you _really_ know what you're doing.
It is not a problem to define a variable in one file and use it in a
completely different file. This is already done for instance with
LINUX_DIR. The only potential problem is when you want to use the
variable in a condition. But that is not the case here, so you can use
FREESCALE_IMX_VERSION etc. below without this include statement, even if
gst-fsl-plugins.mk is read before freescale-imx.mk.
Regards,
Arnout
> +
> +GST_FSL_PLUGINS_VERSION = $(FREESCALE_IMX_VERSION)
> +GST_FSL_PLUGINS_SITE = $(FREESCALE_IMX_SITE)
> +GST_FSL_PLUGINS_SOURCE = gst-fsl-plugins-$(GST_FSL_PLUGINS_VERSION).tar.gz
>
> # Most is LGPLv2+, but some sources are copied from upstream and are
> # LGPLv2.1+, which essentially makes it LGPLv2.1+
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
prev parent reply other threads:[~2013-10-01 20:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 18:06 [Buildroot] [PATCH 0/2] i.MX: update gst-fsl-plugin version Eric Nelson
2013-10-01 18:06 ` [Buildroot] [PATCH 1/2] freescale-imx: separate variable assignment from Makefile Eric Nelson
2013-10-01 18:08 ` Eric Nelson
2013-10-01 19:44 ` Thomas Petazzoni
2013-10-01 21:19 ` Eric Nelson
2013-10-01 21:27 ` Thomas Petazzoni
2013-10-01 21:50 ` Eric Nelson
2013-10-01 18:06 ` [Buildroot] [PATCH 2/2] gst-fsl-plugins: Bump version and change URL to match other i.MX components Eric Nelson
2013-10-01 20:48 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524B351A.6000200@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.