diff for duplicates of <524B376E.6060507@wwwdotorg.org> diff --git a/a/1.txt b/N1/1.txt index 7d72fe9..0cf56ad 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -45,7 +45,3 @@ That assumes that enable_gpio==0 means "none", whereas you've gone to great pains in the rest of the series to allow 0 to be a valid GPIO ID. right now, the default value of samsung_bl_data->enable_gpio is -1, and if !bl_data->enable_gpio, that value won't be propagated across. --- -To unsubscribe from this list: send the line "unsubscribe devicetree" in -the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 3d17547..8a98ba6 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,31 +2,30 @@ "ref\01379972467-11243-6-git-send-email-treding@nvidia.com\0" "ref\0524B14E8.5040302@wwwdotorg.org\0" "ref\020131001204335.GB9201@ulmo.nvidia.com\0" - "ref\020131001204335.GB9201-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org\0" - "From\0Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>\0" + "From\0Stephen Warren <swarren@wwwdotorg.org>\0" "Subject\0Re: [PATCH 05/10] ARM: SAMSUNG: Initialize PWM backlight enable_gpio field\0" "Date\0Tue, 01 Oct 2013 14:58:22 -0600\0" - "To\0Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" - "Cc\0Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>" - Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> - Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> - Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> - Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> - Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Haojian Zhuang <haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> - Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> - Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> - Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Guan Xuetao <gxt-TG0Ac1+ktVePQbnJrJN+5g@public.gmane.org> - devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org - linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - openezx-devel-ZwoEplunGu3n3BO9LpVK+9i2O/JbrIOy@public.gmane.org - linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" + "To\0Thierry Reding <thierry.reding@gmail.com>\0" + "Cc\0Rob Herring <rob.herring@calxeda.com>" + Pawel Moll <pawel.moll@arm.com> + Mark Rutland <mark.rutland@arm.com> + Ian Campbell <ijc+devicetree@hellion.org.uk> + Tony Lindgren <tony@atomide.com> + Eric Miao <eric.y.miao@gmail.com> + Haojian Zhuang <haojian.zhuang@gmail.com> + Ben Dooks <ben-linux@fluff.org> + Kukjin Kim <kgene.kim@samsung.com> + Simon Horman <horms@verge.net.au> + Magnus Damm <magnus.damm@gmail.com> + Guan Xuetao <gxt@mprc.pku.edu.cn> + devicetree@vger.kernel.org + linux-arm-kernel@lists.infradead.org + linux-omap@vger.kernel.org + openezx-devel@lists.openezx.org + linux-samsung-soc@vger.kernel.org + linux-sh@vger.kernel.org + linux-pwm@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "On 10/01/2013 02:43 PM, Thierry Reding wrote:\n" @@ -75,10 +74,6 @@ "That assumes that enable_gpio==0 means \"none\", whereas you've gone to\n" "great pains in the rest of the series to allow 0 to be a valid GPIO\n" "ID. right now, the default value of samsung_bl_data->enable_gpio is\n" - "-1, and if !bl_data->enable_gpio, that value won't be propagated across.\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" - "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + -1, and if !bl_data->enable_gpio, that value won't be propagated across. -1f1e6ed0df54bceee0ec8f718bb8eb6330b2df8b95a8e17019ad8b417d2eb26f +d249bcf2eb615638b0859aa38641162736db62e211a4cecca8eaa920c959eb59
diff --git a/a/1.txt b/N2/1.txt index 7d72fe9..19c5412 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -9,16 +9,13 @@ On 10/01/2013 02:43 PM, Thierry Reding wrote: >>> @@ -70,6 +70,7 @@ static struct samsung_bl_drvdata >>> samsung_dfl_bl_data __initdata = { .max_brightness = 255, >>> .dft_brightness = 255, .pwm_period_ns = 78770, + .enable_gpio ->>> = -1, .init = samsung_bl_init, .exit = ->>> samsung_bl_exit, }, @@ -121,6 +122,10 @@ void __init +>>> = -1, .init = samsung_bl_init, .exit >>> samsung_bl_exit, }, @@ -121,6 +122,10 @@ void __init >>> samsung_bl_set(struct samsung_bl_gpio_info *gpio_info, >>> samsung_bl_data->lth_brightness = bl_data->lth_brightness; if ->>> (bl_data->pwm_period_ns) samsung_bl_data->pwm_period_ns = ->>> bl_data->pwm_period_ns; + if (bl_data->enable_gpio) + +>>> (bl_data->pwm_period_ns) samsung_bl_data->pwm_period_ns >>> bl_data->pwm_period_ns; + if (bl_data->enable_gpio) + >>> samsung_bl_data->enable_gpio = bl_data->enable_gpio; + if >>> (bl_data->enable_gpio_flags) + ->>> samsung_bl_data->enable_gpio_flags = ->>> bl_data->enable_gpio_flags; +>>> samsung_bl_data->enable_gpio_flags >>> bl_data->enable_gpio_flags; >> >> Won't this cause the core pwm_bl driver to request/manipulate the >> GPIO, whereas this driver already does that inside the @@ -38,14 +35,9 @@ pwm_bl's platform data with some other field in a custom data structure. One minor point though: ->>> + if (bl_data->enable_gpio) + samsung_bl_data->enable_gpio = ->>> bl_data->enable_gpio; +>>> + if (bl_data->enable_gpio) + samsung_bl_data->enable_gpio >>> bl_data->enable_gpio; -That assumes that enable_gpio==0 means "none", whereas you've gone to +That assumes that enable_gpio=0 means "none", whereas you've gone to great pains in the rest of the series to allow 0 to be a valid GPIO ID. right now, the default value of samsung_bl_data->enable_gpio is -1, and if !bl_data->enable_gpio, that value won't be propagated across. --- -To unsubscribe from this list: send the line "unsubscribe devicetree" in -the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 3d17547..822bb55 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,31 +2,10 @@ "ref\01379972467-11243-6-git-send-email-treding@nvidia.com\0" "ref\0524B14E8.5040302@wwwdotorg.org\0" "ref\020131001204335.GB9201@ulmo.nvidia.com\0" - "ref\020131001204335.GB9201-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org\0" - "From\0Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>\0" + "From\0Stephen Warren <swarren@wwwdotorg.org>\0" "Subject\0Re: [PATCH 05/10] ARM: SAMSUNG: Initialize PWM backlight enable_gpio field\0" - "Date\0Tue, 01 Oct 2013 14:58:22 -0600\0" - "To\0Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" - "Cc\0Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>" - Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> - Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> - Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> - Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> - Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Haojian Zhuang <haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> - Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> - Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> - Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Guan Xuetao <gxt-TG0Ac1+ktVePQbnJrJN+5g@public.gmane.org> - devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org - linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - openezx-devel-ZwoEplunGu3n3BO9LpVK+9i2O/JbrIOy@public.gmane.org - linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" + "Date\0Tue, 01 Oct 2013 20:58:22 +0000\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On 10/01/2013 02:43 PM, Thierry Reding wrote:\n" @@ -40,16 +19,13 @@ ">>> @@ -70,6 +70,7 @@ static struct samsung_bl_drvdata\n" ">>> samsung_dfl_bl_data __initdata = { .max_brightness = 255, \n" ">>> .dft_brightness = 255, .pwm_period_ns = 78770, +\t\t.enable_gpio\n" - ">>> = -1, .init = samsung_bl_init, .exit =\n" - ">>> samsung_bl_exit, }, @@ -121,6 +122,10 @@ void __init\n" + ">>> = -1, .init = samsung_bl_init, .exit >>> samsung_bl_exit, }, @@ -121,6 +122,10 @@ void __init\n" ">>> samsung_bl_set(struct samsung_bl_gpio_info *gpio_info, \n" ">>> samsung_bl_data->lth_brightness = bl_data->lth_brightness; if\n" - ">>> (bl_data->pwm_period_ns) samsung_bl_data->pwm_period_ns =\n" - ">>> bl_data->pwm_period_ns; +\tif (bl_data->enable_gpio) +\n" + ">>> (bl_data->pwm_period_ns) samsung_bl_data->pwm_period_ns >>> bl_data->pwm_period_ns; +\tif (bl_data->enable_gpio) +\n" ">>> samsung_bl_data->enable_gpio = bl_data->enable_gpio; +\tif\n" ">>> (bl_data->enable_gpio_flags) +\n" - ">>> samsung_bl_data->enable_gpio_flags =\n" - ">>> bl_data->enable_gpio_flags;\n" + ">>> samsung_bl_data->enable_gpio_flags >>> bl_data->enable_gpio_flags;\n" ">> \n" ">> Won't this cause the core pwm_bl driver to request/manipulate the\n" ">> GPIO, whereas this driver already does that inside the\n" @@ -69,16 +45,11 @@ "\n" "One minor point though:\n" "\n" - ">>> +\tif (bl_data->enable_gpio) +\t\tsamsung_bl_data->enable_gpio =\n" - ">>> bl_data->enable_gpio;\n" + ">>> +\tif (bl_data->enable_gpio) +\t\tsamsung_bl_data->enable_gpio >>> bl_data->enable_gpio;\n" "\n" - "That assumes that enable_gpio==0 means \"none\", whereas you've gone to\n" + "That assumes that enable_gpio=0 means \"none\", whereas you've gone to\n" "great pains in the rest of the series to allow 0 to be a valid GPIO\n" "ID. right now, the default value of samsung_bl_data->enable_gpio is\n" - "-1, and if !bl_data->enable_gpio, that value won't be propagated across.\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" - "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + -1, and if !bl_data->enable_gpio, that value won't be propagated across. -1f1e6ed0df54bceee0ec8f718bb8eb6330b2df8b95a8e17019ad8b417d2eb26f +5fad825503aa0b2d5855bcd2e0deb909823baa1f42618afeb441fb8eca4544a1
diff --git a/a/1.txt b/N3/1.txt index 7d72fe9..0cf56ad 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -45,7 +45,3 @@ That assumes that enable_gpio==0 means "none", whereas you've gone to great pains in the rest of the series to allow 0 to be a valid GPIO ID. right now, the default value of samsung_bl_data->enable_gpio is -1, and if !bl_data->enable_gpio, that value won't be propagated across. --- -To unsubscribe from this list: send the line "unsubscribe devicetree" in -the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N3/content_digest index 3d17547..3d286ac 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -2,31 +2,10 @@ "ref\01379972467-11243-6-git-send-email-treding@nvidia.com\0" "ref\0524B14E8.5040302@wwwdotorg.org\0" "ref\020131001204335.GB9201@ulmo.nvidia.com\0" - "ref\020131001204335.GB9201-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org\0" - "From\0Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>\0" - "Subject\0Re: [PATCH 05/10] ARM: SAMSUNG: Initialize PWM backlight enable_gpio field\0" + "From\0swarren@wwwdotorg.org (Stephen Warren)\0" + "Subject\0[PATCH 05/10] ARM: SAMSUNG: Initialize PWM backlight enable_gpio field\0" "Date\0Tue, 01 Oct 2013 14:58:22 -0600\0" - "To\0Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" - "Cc\0Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>" - Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> - Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> - Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> - Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> - Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Haojian Zhuang <haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> - Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> - Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> - Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Guan Xuetao <gxt-TG0Ac1+ktVePQbnJrJN+5g@public.gmane.org> - devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org - linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - openezx-devel-ZwoEplunGu3n3BO9LpVK+9i2O/JbrIOy@public.gmane.org - linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On 10/01/2013 02:43 PM, Thierry Reding wrote:\n" @@ -75,10 +54,6 @@ "That assumes that enable_gpio==0 means \"none\", whereas you've gone to\n" "great pains in the rest of the series to allow 0 to be a valid GPIO\n" "ID. right now, the default value of samsung_bl_data->enable_gpio is\n" - "-1, and if !bl_data->enable_gpio, that value won't be propagated across.\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" - "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + -1, and if !bl_data->enable_gpio, that value won't be propagated across. -1f1e6ed0df54bceee0ec8f718bb8eb6330b2df8b95a8e17019ad8b417d2eb26f +6fdee6c9cc0b60d8dd00ae648ae1bd628bbba5b470afe05c85a35a770bd01c56
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.