From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRKkK-0006Nb-9l for qemu-devel@nongnu.org; Wed, 02 Oct 2013 07:37:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRKkB-0003Zh-Mx for qemu-devel@nongnu.org; Wed, 02 Oct 2013 07:37:36 -0400 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:54896 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRKkB-0003ZO-AN for qemu-devel@nongnu.org; Wed, 02 Oct 2013 07:37:27 -0400 Message-ID: <524C0572.3060801@kamp.de> Date: Wed, 02 Oct 2013 13:37:22 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1378984634-765-1-git-send-email-pbonzini@redhat.com> <1378984634-765-9-git-send-email-pbonzini@redhat.com> <52388EF5.4030108@weilnetz.de> <52388F81.7030102@redhat.com> <523AA6A0.1060209@kamp.de> <523B0053.10208@redhat.com> In-Reply-To: <523B0053.10208@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 08/11] iscsi: add .bdrv_get_block_status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Stefan Weil , qemu-devel@nongnu.org, Anthony Liguori Am 19.09.2013 15:46, schrieb Paolo Bonzini: > Il 19/09/2013 09:24, Peter Lieven ha scritto: >> do we still need this patch? if yes I can sent one shortly. > No, Stefan prepared it. I'll send a pull request shortly. The patch disables iscsi_get_block_status completely. The C preprocessor can't check for enumeration constants. I would check for LIBISCSI_FEATURE_IOVECTOR instead. At that point the enumeration constant already existed. Peter