Re: [PATCH 3/6] arm: shmobile: Add internal PCI support to RCAR Gen2

[Valentine <valentine.barshak@cogentembedded.com>]

On 10/02/2013 04:13 AM, Kuninori Morimoto wrote:
>
> Hi Valentine
>

Hi Morimoto-san,

>> This adds internal PCI controller support to RCAR Gen2 platform.
>> There are 3 PCI controllers available with only a EHCI/OHCI
>> device present on each one. The controllers do not support
>> I/O port space mapping and it is not needed here.
>>
>> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
>> ---
>>
>>   arch/arm/mach-shmobile/Kconfig         |   1 +
>>   arch/arm/mach-shmobile/Makefile        |   4 +
>>   arch/arm/mach-shmobile/pci-rcar-gen2.c | 339 +++++++++++++++++++++++++++++++++
>>   3 files changed, 344 insertions(+)
> (snip)
>> +static struct platform_driver rcar_pci_driver = {
>> +	.driver = {
>> +		.name = "pci-rcar-gen2",
>> +	},
>> +};
>> +
>> +static int __init rcar_pci_init(void)
>> +{
>> +	return platform_driver_probe(&rcar_pci_driver, rcar_pci_probe);
>> +}
>
> driver should exist under ${LINUX}/driver, not ${LINUX}/arch/arm/

Thanks, I'll move it to drivers/pci/host.

(was mislead by some PCI drivers still residing in arch/arm
for other platforms.)

>
> Best regards
> ---
> Kuninori Morimoto
>

Thanks,
Val.