From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valentine Date: Wed, 02 Oct 2013 12:17:00 +0000 Subject: Re: [PATCH 5/6] arm: shmobile: lager: Add internal PCI support Message-Id: <524C0EBC.5010105@cogentembedded.com> List-Id: References: <1380652251-8143-6-git-send-email-valentine.barshak@cogentembedded.com> In-Reply-To: <1380652251-8143-6-git-send-email-valentine.barshak@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On 10/02/2013 04:18 AM, Kuninori Morimoto wrote: > > Hi Valentine Hi Morimoto-san, > >> This adds internal PCI/USB host support to Lager board. >> There are 3 internal PCI bus controllers with only a EHCI/OHCI >> device present on each one. This gives us 3 USB host channels. >> Channel 0 is shared with the USBHS function module. >> Channel 2 is shared with the USBSS (XHCI) device. >> >> Currently no channel configuration is supported, >> and the default settings are assumed: >> Channel 0 - USBHS >> Channel 1 - PCI/USB host >> Channel 2 - PCI/USB host >> >> Signed-off-by: Valentine Barshak >> --- > (snip) >> /* USB0 */ >> - PIN_MAP_MUX_GROUP_DEFAULT("renesas_usbhs", "pfc-r8a7790", >> + PIN_MAP_MUX_GROUP_DEFAULT(LAGER_USB0_DEVNAME, "pfc-r8a7790", >> "usb0", "usb0"), > > I found definition of "LAGER_USB0_DEVNAME" on [6/6] patch, > but [5/6] patch is using it. > Good catch. Thanks! > Best regards > --- > Kuninori Morimoto > Thanks, Val.