All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, guido.aulisi@gmail.com
Subject: Re: [PATCH] ALSA: snd-usb-usx2y: fix start frame mask
Date: Wed, 02 Oct 2013 15:49:57 +0200	[thread overview]
Message-ID: <524C2485.2030301@gmail.com> (raw)
In-Reply-To: <s5hr4c3u6la.wl%tiwai@suse.de>

On 02.10.2013 15:48, Takashi Iwai wrote:
> At Wed,  2 Oct 2013 15:39:57 +0200,
> Daniel Mack wrote:
>>
>> This patch is based on a change proposed by Guido Aulisi in a
>> discussion on LAU which can be followed here:
>>
>>   http://linuxaudio.org/mailarchive/lau/2013/5/20/200177
>>
>> Cc: fzu@wemgehoertderstaat.de
>> Original-code-by: Guido Aulisi <guido.aulisi@gmail.com>
>> Tested-by: Dr Nicholas J Bailey <nicholas.bailey@glasgow.ac.uk>
>> Signed-off-by: Daniel Mack <zonque@gmail.com>
> 
> Why this fixes the issue at all?
> There is no explanation in the thread.

I have no idea of this driver.

> If any, the sanity check there is simply bogus for ehci, and it'd be
> better to get rid of it completely.

You're right. I guess, however, that there was a reason to add the code
in the first place.

Anyway, I'll send another patch that does the removal.

Thanks,
Daniel

  reply	other threads:[~2013-10-02 13:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-02 13:39 [PATCH] ALSA: snd-usb-usx2y: fix start frame mask Daniel Mack
2013-10-02 13:48 ` Takashi Iwai
2013-10-02 13:49   ` Daniel Mack [this message]
2013-10-03  9:59     ` Guido Aulisi
2013-10-03 14:35       ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524C2485.2030301@gmail.com \
    --to=zonque@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=guido.aulisi@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.