All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Spencer <maillist-alsa@barfooze.de>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: alsa-lib 1.0.27.2 and musl
Date: Wed, 02 Oct 2013 17:02:42 +0200	[thread overview]
Message-ID: <524C3592.4060001@barfooze.de> (raw)
In-Reply-To: <20130917172225.GI14246@waldemar-brodkorb.de>

On 09/17/2013 07:22 PM, Waldemar Brodkorb wrote:
> Hi Developers,
>
> I am trying to cross-compile alsa-lib with a musl¹ libc based
> toolchain. Unfortunately src/compat/hsearch_r.c is failing to
> compile, because of some glibc specific macros (like _P) normally
> defined in sys/cdefs.h. After grepping through the code I can not
> find any consumer for any functions implemented in hsearch_r.c.
> When I just comment out the code, everything compiles fine.
>
> Seems that that usage of hsearch functions was removed in the code
> long time ago.
> commit 273d115de05574251bdd661747ecb68449a5cf1d
> Author: Jaroslav Kysela<perex@perex.cz>
> Date:   Sat Jul 15 10:20:32 2000 +0000
>
>      Removed old mixer API functions.
>      Added simple control layer (experimental).
>
> Can it just be removed?

Seems so, yes. can you come up with a patch that removes 
src/compat/hsearch_r.c plus any references from Makefile.*'s ?
the configure check "checking for hsearch_r" should also be removed from 
configure.ac.


if so please send it here with a title like
"[PATCH]: remove unnecessary/obsolete compat/hsearch_r.c"
and a comment mentioning its removal with the above commit, plus that it 
highly increases portability for non-glibc systems.

thanks.


>
> thanks for any advice or comment.
>
> best regards
>   Waldemar
>
>
> ¹ http://www.musl-libc.org/

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2013-10-02 15:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17 17:22 alsa-lib 1.0.27.2 and musl Waldemar Brodkorb
2013-10-02 15:02 ` John Spencer [this message]
2013-10-02 15:26   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524C3592.4060001@barfooze.de \
    --to=maillist-alsa@barfooze.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=wbx@openadk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.